From 10321be656537d5708719394e6cee7a0a806ee75 Mon Sep 17 00:00:00 2001
From: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Tue, 12 Nov 2024 20:05:57 +0000
Subject: [PATCH] snmp.lua: add configurable timeout

---
 nselib/snmp.lua | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/nselib/snmp.lua b/nselib/snmp.lua
index b732160a5..5c3aeb261 100644
--- a/nselib/snmp.lua
+++ b/nselib/snmp.lua
@@ -2,6 +2,7 @@
 -- SNMP library.
 --
 -- @args snmp.version The SNMP protocol version. Use <code>"v1"</code> or <code>0</code> for SNMPv1 (default) and <code>"v2c"</code> or <code>1</code> for SNMPv2c.
+-- @args snmp.timeout The timeout for SNMP queries. Default: varies by target responsiveness, up to 5s.
 --
 -- @author Patrik Karlsson <patrik@cqure.net>
 -- @author Gioacchino Mazzurco <gmazzurco89@gmail.com>
@@ -19,6 +20,12 @@ local table = require "table"
 _ENV = stdnse.module("snmp", stdnse.seeall)
 
 
+local arg_timeout = stdnse.parse_timespec(stdnse.get_script_args("snmp.timeout"))
+if arg_timeout then
+  arg_timeout = arg_timeout * 1000
+end
+local default_max_timeout = 5000 --ms
+
 -- SNMP ASN.1 Encoders
 local tagEncoder = {}
 
@@ -484,10 +491,9 @@ Helper = {
       end
     end
 
-    o.options = options or {
-      timeout = 5000,
-      version = default_version
-    }
+    o.options = options or {}
+    o.options.timeout = o.options.timeout or arg_timeout
+    o.options.version = o.options.version or default_version
 
     return o
   end,
@@ -498,7 +504,7 @@ Helper = {
   -- @return status true on success, false on failure
   connect = function( self )
     self.socket = nmap.new_socket()
-    self.socket:set_timeout(self.options.timeout)
+    self.socket:set_timeout(self.options.timeout or stdnse.get_timeout(self.host, default_max_timeout))
     local status, err = self.socket:connect(self.host, self.port)
     if ( not(status) ) then return false, err end