From 121cc35de6c8ca605bb46016330c218740e243cd Mon Sep 17 00:00:00 2001
From: patrik <patrik@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Sun, 7 Oct 2012 12:54:31 +0000
Subject: [PATCH] nse_check_globals cleanup

---
 nselib/cassandra.lua             | 2 +-
 scripts/cassandra-brute.nse      | 4 +++-
 scripts/cassandra-info.nse       | 1 +
 scripts/http-method-tamper.nse   | 1 +
 scripts/ipv6-ra-flood.nse        | 2 +-
 scripts/oracle-brute-stealth.nse | 3 ++-
 6 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/nselib/cassandra.lua b/nselib/cassandra.lua
index c5bbada6c..a27841a61 100644
--- a/nselib/cassandra.lua
+++ b/nselib/cassandra.lua
@@ -189,7 +189,7 @@ function login (socket,username,password)
   end
   local _, size = bin.unpack(">I", response, 1)
 
-  loginresp = string.sub(response,5,17)
+  local loginresp = string.sub(response,5,17)
   if (loginresp ~= CASSANDRARESP..pack4str("login")) then  
     return false, "protocol error"
   end
diff --git a/scripts/cassandra-brute.nse b/scripts/cassandra-brute.nse
index 16fb37e02..12577cd49 100644
--- a/scripts/cassandra-brute.nse
+++ b/scripts/cassandra-brute.nse
@@ -1,8 +1,10 @@
+local bin = require "bin"
 local brute = require "brute"
 local creds = require "creds"
 local nmap = require "nmap"
 local shortport = require "shortport"
 local stdnse = require "stdnse"
+local string = require "string"
 local cassandra = require "cassandra"
 
 description = [[
@@ -47,7 +49,7 @@ Driver = {
 
         -- bit faster login function than in cassandra library (no protocol error checks)
 	login = function(self, username, password)
-		local response, magic, size
+		local response, magic, size, _
 		local loginstr = cassandra.loginstr (username, password)
 
 		local status, err = self.socket:send(bin.pack(">I",string.len(loginstr)))
diff --git a/scripts/cassandra-info.nse b/scripts/cassandra-info.nse
index d09ff8ef2..0db91b9af 100644
--- a/scripts/cassandra-info.nse
+++ b/scripts/cassandra-info.nse
@@ -4,6 +4,7 @@ local shortport = require "shortport"
 local stdnse = require "stdnse"
 local bin = require "bin"
 local string = require "string"
+local table = require "table"
 
 local cassandra = stdnse.silent_require "cassandra"
 
diff --git a/scripts/http-method-tamper.nse b/scripts/http-method-tamper.nse
index 9ed5b497b..8b31dc926 100644
--- a/scripts/http-method-tamper.nse
+++ b/scripts/http-method-tamper.nse
@@ -64,6 +64,7 @@ local table = require "table"
 local httpspider = require "httpspider"
 local vulns = require "vulns"
 local url = require "url"
+local string = require "string"
 
 portrule = shortport.http
 
diff --git a/scripts/ipv6-ra-flood.nse b/scripts/ipv6-ra-flood.nse
index 40d7b0f23..5a27c102e 100644
--- a/scripts/ipv6-ra-flood.nse
+++ b/scripts/ipv6-ra-flood.nse
@@ -185,7 +185,7 @@ local function broadcast_on_interface(iface)
 end
 
 function action()
-	interface = get_interface()
+	local interface = get_interface()
 	
 	broadcast_on_interface(interface)
 end
diff --git a/scripts/oracle-brute-stealth.nse b/scripts/oracle-brute-stealth.nse
index 9d241aab4..7ce38cc6c 100644
--- a/scripts/oracle-brute-stealth.nse
+++ b/scripts/oracle-brute-stealth.nse
@@ -5,6 +5,7 @@ local io = require "io"
 local nmap = require "nmap"
 local shortport = require "shortport"
 local stdnse = require "stdnse"
+local string = require "string"
 local tns = require "tns"
 local unpwdb = require "unpwdb"
 
@@ -118,7 +119,7 @@ Driver =
 		local status, data = self.helper:StealthLogin( username, password )
 
 		if ( data["AUTH_VFR_DATA"] ) then
-			hash = string.format("$o5logon$%s*%s", data["AUTH_SESSKEY"], data["AUTH_VFR_DATA"])
+			local hash = string.format("$o5logon$%s*%s", data["AUTH_SESSKEY"], data["AUTH_VFR_DATA"])
 			if ( johnfile ) then
 				johnfile:write(("%s:%s\n"):format(username,hash))
 			end