From 1b39988bf9ab9caa32d7604ad53d7c4daf9ed281 Mon Sep 17 00:00:00 2001
From: nnposter <nnposter@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Wed, 16 Dec 2020 17:54:15 +0000
Subject: [PATCH] Correct the return value of smb2.negotiate_v2

As documented, the function should return the negotiated SMB2 dialect,
not just reflect back the dialect override table.
---
 nselib/smb2.lua                | 2 +-
 scripts/smb2-security-mode.nse | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nselib/smb2.lua b/nselib/smb2.lua
index 5aff1ea9a..861ebf3ea 100644
--- a/nselib/smb2.lua
+++ b/nselib/smb2.lua
@@ -371,7 +371,7 @@ function negotiate_v2(smb, overrides)
   local security_buffer_offset, security_buffer_length, neg_context_offset
   security_buffer_offset, security_buffer_length, neg_context_offset = string.unpack("<I2 I2 I4", data)
   if status == 0 then
-    return true, overrides['Dialects']
+    return true, smb['dialect']
   else
     return false, string.format("Status error code:%s",status)
   end
diff --git a/scripts/smb2-security-mode.nse b/scripts/smb2-security-mode.nse
index 845a41d2d..564bb2d24 100644
--- a/scripts/smb2-security-mode.nse
+++ b/scripts/smb2-security-mode.nse
@@ -77,7 +77,7 @@ action = function(host,port)
       elseif not(signing_enabled) and signing_required then
         table.insert(message_signing, "Message signing is disabled!")
       end
-      output[stdnse.tohex(dialect[1], {separator = ".", group = 2})] = message_signing
+      output[stdnse.tohex(dialect, {separator = ".", group = 2})] = message_signing
       -- We exit after first accepted dialect,
       --  SMB signing configuration appears to be global so
       --  there is no point of trying other dialects.