PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-28 02:19:04 +00:00
Code Issues Projects Releases Wiki Activity

Avoid using hard-coded numerical codes. Replace repeated expression with a local variable

Browse Source
This commit is contained in:
nnposter
2024-07-04 03:21:53 +00:00
parent f4b092259c
commit 29741a6360
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
nselib/mssql.lua
View File

@@ -3134,12 +3134,13 @@ Helper =
for i=1, #colinfo do
local val
if ( ColumnData.Parse[colinfo[i].type] ) then
if not ( colinfo[i].type == 106 or colinfo[i].type == 108) then
pos, val = ColumnData.Parse[colinfo[i].type](data, pos)
else
local coltype = colinfo[i].type
if ( ColumnData.Parse[coltype] ) then
if coltype == DataTypes.DECIMALNTYPE or coltype == DataTypes.NUMERICNTYPE then
-- decimal / numeric types need precision and scale passed.
pos, val = ColumnData.Parse[colinfo[i].type]( colinfo[i].precision, colinfo[i].scale, data, pos)
pos, val = ColumnData.Parse[coltype]( colinfo[i].precision, colinfo[i].scale, data, pos)
else
pos, val = ColumnData.Parse[coltype](data, pos)
end
if ( -1 == pos ) then
@@ -3147,7 +3148,7 @@ Helper =
end
table.insert(columns, val)
else
return false, ("unknown datatype=0x%X"):format(colinfo[i].type)
return false, ("unknown datatype=0x%X"):format(coltype)
end
end
table.insert(rows, columns)