PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-06 04:31:29 +00:00
Code Issues Projects Releases Wiki Activity

Remove FIXME comment: newstrlen *is* checked.

Browse Source 
I added this a long time ago, and decided to check it. In fact,
newstrlen is used to calculate newstrend, and each section of the
template is checked to ensure it does not go past newstrend, so the
intent is met and the length is not exceeded. I still think it could be
written more clearly, but it's good for now. #1834
This commit is contained in:
dmiller
2020-01-02 16:04:29 +00:00
parent ea8917ca1d
commit 2f91473a06
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
service_scan.cc
View File

@@ -914,7 +914,6 @@ static char *substvar(char *tmplvar, char **tmplvarend,
// matches in ovector. The NUL-terminated newly composted string is
// placed into 'newstr', as long as it doesn't exceed 'newstrlen'
// bytes. Trailing whitespace and commas are removed. Returns zero for success
// FIXME: The newstrlen argument is not actually checked, is it?
//
// The transform argument is a function pointer. If not NULL, the given
// function is applied to all substitutions before they are inserted