From 31935a45d47b17de71b201fdfee3d0ce811994ef Mon Sep 17 00:00:00 2001 From: david Date: Fri, 4 Feb 2011 08:46:14 +0000 Subject: [PATCH] o [NSE] Fixed some portrules that used shortport functions incorrectly and always returned true in dns-zone-transfer and ftp-proftpd-backdoor. [Jost Krieger] --- CHANGELOG | 4 ++++ scripts/dns-zone-transfer.nse | 2 +- scripts/ftp-proftpd-backdoor.nse | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 0f967a5ae..528338154 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,9 @@ # Nmap Changelog ($Id$); -*-text-*- +o [NSE] Fixed some portrules that used shortport functions incorrectly + and always returned true in dns-zone-transfer and + ftp-proftpd-backdoor. [Jost Krieger] + o [Ndiff] Added support for prerule and postrule scripts. [David] o [Ndiff] Fixed ndiff.dtd to include two elements that can be diffed: diff --git a/scripts/dns-zone-transfer.nse b/scripts/dns-zone-transfer.nse index f34dce5a9..12dde3579 100644 --- a/scripts/dns-zone-transfer.nse +++ b/scripts/dns-zone-transfer.nse @@ -112,7 +112,7 @@ prerule = function() end portrule = function(host, port) - if shortport.portnumber(53, 'tcp') then + if shortport.portnumber(53, 'tcp')(host, port) then dns_opts.domain, dns_opts.addall = stdnse.get_script_args( {"dns-zone-transfer.domain", "dnszonetransfer.domain"}, {"dns-zone-transfer.addall","dnszonetransfer.addall"} diff --git a/scripts/ftp-proftpd-backdoor.nse b/scripts/ftp-proftpd-backdoor.nse index 9bfda9339..81a7504f6 100644 --- a/scripts/ftp-proftpd-backdoor.nse +++ b/scripts/ftp-proftpd-backdoor.nse @@ -43,7 +43,7 @@ portrule = function (host, port) return false end - return shortport.port_or_service(21, "ftp") + return shortport.port_or_service(21, "ftp")(host, port) end action = function(host, port)