PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-06 12:41:29 +00:00
Code Issues Projects Releases Wiki Activity

Fixed a "minor" problem with our WinPcap installer (instead of running our uninstaller if our InstalledBy string was present, it would run "Nmap /S _?=$INSTDIR"), which caused Nmap to briefly display its help output if it was in the same directory (or presumably in the system/user's PATH).

Browse Source
This commit is contained in:
robert
2011-08-20 21:57:29 +00:00
parent 975cc24cf9
commit 328fb8091f
2 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mswin32/winpcap/winpcap-nmap.nsi
View File

@@ -207,8 +207,10 @@ Function .onInit
return
silent_uninstall:
; Our old UninstallString is present, should have quotes and uninstall.exe location
; and should support a silent uninstall by passing /S to it.
; Our InstalledBy string is present, UninstallString should have quotes and uninstall.exe location
; and this file should support a silent uninstall by passing /S to it.
; we could read QuietUninstallString, but this should be exactly the same as UninstallString with /S on the end.
ReadRegStr $0 "HKLM" "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\WinPcapInst" "UninstallString"
ExecWait '$0 /S _?=$INSTDIR'
return

9
todo/nmap.txt
View File

@@ -27,15 +27,6 @@ o Investigate a probe/response matching problem reported by QA Cafe
Matthew Stickey and Joe McEachern of QA Cafe. See this thread:
http://seclists.org/nmap-dev/2011/q3/227
o When our winpcap installer is run in silent mode
(e.g. "winpcap-nmap-4.12.exe /S"), it seems to execute nmap.exe if
that binary exists in the same directory. This leads to a cmd.exe
window briefly poping up as Nmap displays its console help output.
Moving the Winpcap installer into its own subdir and running it from
there seems to fix this (because it then can't find nmap.exe to
run), but it would be better to determine why this is happening in
the first place and fix it.
==Things needed for next STABLE release go ABOVE THIS LINE==
o We should document Ron's sample script