From 3421d01d2e08bbcbb2c50dee15606246414919aa Mon Sep 17 00:00:00 2001 From: nnposter Date: Fri, 17 Jul 2020 20:56:39 +0000 Subject: [PATCH] Clarify upper boundary for variable-length numerical fields --- nselib/mqtt.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/nselib/mqtt.lua b/nselib/mqtt.lua index 7c1695d7c..f0587405a 100644 --- a/nselib/mqtt.lua +++ b/nselib/mqtt.lua @@ -797,9 +797,9 @@ end -- @param num The value of the field. -- @return A variable-length field. MQTT.length_build = function(num) - -- This field represents a limited range of integers. + -- This field represents a limited range of integers (0 through 128^4-1) assert(num >= 0) - assert(num <= 268435455) + assert(num < 0x10000000) local field = {} repeat @@ -854,9 +854,9 @@ MQTT.length_parse = function(buf, pos) offset = offset + 1 until (byte & 0x80) == 0 - -- This field represents a limited range of integers. + -- This field represents a limited range of integers (0 through 128^4-1) assert(num >= 0) - assert(num <= 268435455) + assert(num < 0x10000000) return pos, num end