diff --git a/nselib/netbios.lua b/nselib/netbios.lua
index d0b9e5ae3..d2783877f 100644
--- a/nselib/netbios.lua
+++ b/nselib/netbios.lua
@@ -264,12 +264,27 @@ function do_nbstat(host)
local socket = nmap.new_socket()
local encoded_name = name_encode("*")
local statistics
+ local reg
+ if type(host) == "string" then --ip
+ stdnse.print_debug(3, "Performing nbstat on host '%s'", host)
+ nmap.registry.netbios = nmap.registry.netbios or {}
+ nmap.registry.netbios[host] = nmap.registry.netbios[host] or {}
+ reg = nmap.registry.netbios[host]
+ else
+ stdnse.print_debug(3, "Performing nbstat on host '%s'", host.ip)
+ if host.registry.netbios == nil and
+ nmap.registry.netbios ~= nil and
+ nmap.registry.netbios[host.ip] ~= nil then
+ host.registry.netbios = nmap.registry.netbios[host.ip]
+ end
+ host.registry.netbios = host.registry.netbios or {}
+ reg = host.registry.netbios
+ end
- stdnse.print_debug(3, "Performing nbstat on host '%s'", host)
- -- Check if it's cased in the registry for this host
- if(nmap.registry["nbstat_names_" .. host] ~= nil) then
+ -- Check if it's cached in the registry for this host
+ if(reg["nbstat_names"] ~= nil) then
stdnse.print_debug(3, " |_ [using cached value]")
- return true, nmap.registry["nbstat_names_" .. host], nmap.registry["nbstat_statistics_" .. host]
+ return true, reg["nbstat_names"], reg["nbstat_statistics"]
end
-- Create the query header
@@ -369,8 +384,8 @@ function do_nbstat(host)
pos, statistics = bin.unpack(string.format(">A%d", rrlength), result, pos)
-- Put it in the registry, in case anybody else needs it
- nmap.registry["nbstat_names_" .. host] = names
- nmap.registry["nbstat_statistics_" .. host] = statistics
+ reg["nbstat_names"] = names
+ reg["nbstat_statistics"] = statistics
return true, names, statistics
diff --git a/nselib/smbauth.lua b/nselib/smbauth.lua
index 3836059ec..e94490de7 100644
--- a/nselib/smbauth.lua
+++ b/nselib/smbauth.lua
@@ -105,11 +105,11 @@ local ACCOUNT_TYPES = {
}
local function account_exists(host, username, domain)
- if(nmap.registry[host.ip] == nil or nmap.registry[host.ip]['smbaccounts'] == nil) then
+ if(host.registry['smbaccounts'] == nil) then
return false
end
- for i, j in pairs(nmap.registry[host.ip]['smbaccounts']) do
+ for i, j in pairs(host.registry['smbaccounts']) do
if(j['username'] == username and j['domain'] == domain) then
return true
end
@@ -120,13 +120,13 @@ end
function next_account(host, num)
if(num == nil) then
- if(nmap.registry[host.ip]['smbindex'] == nil) then
- nmap.registry[host.ip]['smbindex'] = 1
+ if(host.registry['smbindex'] == nil) then
+ host.registry['smbindex'] = 1
else
- nmap.registry[host.ip]['smbindex'] = nmap.registry[host.ip]['smbindex'] + 1
+ host.registry['smbindex'] = host.registry['smbindex'] + 1
end
else
- nmap.registry[host.ip]['smbindex'] = num
+ host.registry['smbindex'] = num
end
end
@@ -165,11 +165,8 @@ function add_account(host, username, domain, password, password_hash, hash_type,
return
end
- if(nmap.registry[host.ip] == nil) then
- nmap.registry[host.ip] = {}
- end
- if(nmap.registry[host.ip]['smbaccounts'] == nil) then
- nmap.registry[host.ip]['smbaccounts'] = {}
+ if(host.registry['smbaccounts'] == nil) then
+ host.registry['smbaccounts'] = {}
end
-- Determine the type of account, if it wasn't given
@@ -204,10 +201,10 @@ function add_account(host, username, domain, password, password_hash, hash_type,
new_entry['account_type'] = account_type
-- Insert the new entry into the table
- table.insert(nmap.registry[host.ip]['smbaccounts'], new_entry)
+ table.insert(host.registry['smbaccounts'], new_entry)
-- Sort the table based on the account type (we want anonymous at the end, administrator at the front)
- table.sort(nmap.registry[host.ip]['smbaccounts'], function(a,b) return a['account_type'] > b['account_type'] end)
+ table.sort(host.registry['smbaccounts'], function(a,b) return a['account_type'] > b['account_type'] end)
-- Print a debug message
stdnse.print_debug(1, "SMB: Added account '%s' to account list", username)
@@ -215,7 +212,7 @@ function add_account(host, username, domain, password, password_hash, hash_type,
-- Reset the credentials
next_account(host, 1)
--- io.write("\n\n" .. nsedebug.tostr(nmap.registry[host.ip]['smbaccounts']) .. "\n\n")
+-- io.write("\n\n" .. nsedebug.tostr(host.registry['smbaccounts']) .. "\n\n")
end
---Retrieve the current set of credentials set in the registry. If these fail, next_credentials should be
@@ -225,12 +222,12 @@ end
--@return (result, username, domain, password, password_hash, hash_type) If result is false, username is an error message. Otherwise, username and password are
-- the current username and password that should be used.
function get_account(host)
- if(nmap.registry[host.ip]['smbindex'] == nil) then
- nmap.registry[host.ip]['smbindex'] = 1
+ if(host.registry['smbindex'] == nil) then
+ host.registry['smbindex'] = 1
end
- local index = nmap.registry[host.ip]['smbindex']
- local account = nmap.registry[host.ip]['smbaccounts'][index]
+ local index = host.registry['smbindex']
+ local account = host.registry['smbaccounts'][index]
if(account == nil) then
return false, "No accounts left to try"
@@ -244,18 +241,13 @@ end
--
--@param host The host object.
function init_account(host)
- -- Create the key if it exists
- if(nmap.registry[host.ip] == nil) then
- nmap.registry[host.ip] = {}
- end
-
-- Don't run this more than once for each host
- if(nmap.registry[host.ip]['smbaccounts'] ~= nil) then
+ if(host.registry['smbaccounts'] ~= nil) then
return
end
-- Create the list
- nmap.registry[host.ip]['smbaccounts'] = {}
+ host.registry['smbaccounts'] = {}
-- Add the anonymous/guest accounts
add_account(host, '', '', '', nil, 'none')
diff --git a/scripts/cvs-brute-repository.nse b/scripts/cvs-brute-repository.nse
index 465c4082b..d4eb2b067 100644
--- a/scripts/cvs-brute-repository.nse
+++ b/scripts/cvs-brute-repository.nse
@@ -66,10 +66,8 @@ Driver =
if ( not(status) and err:match("I HATE YOU") ) then
-- let's store the repositories in the registry so the brute
-- script can use them later.
- nmap.registry.cvs = nmap.registry.cvs or {}
- nmap.registry.cvs[self.host.ip] = nmap.registry.cvs[self.host.ip] or {}
- nmap.registry.cvs[self.host.ip].repos = nmap.registry.cvs[self.host.ip].repos or {}
- table.insert(nmap.registry.cvs[self.host.ip].repos, password)
+ self.host.registry.cvs_repos = self.host.registry.cvs_repos or {}
+ table.insert(self.host.registry.cvs_repos, password)
return true, brute.Account:new(username, password, 0)
end
return false, brute.Error:new( "Incorrect password" )
diff --git a/scripts/cvs-brute.nse b/scripts/cvs-brute.nse
index 47816e570..a3c82bed9 100644
--- a/scripts/cvs-brute.nse
+++ b/scripts/cvs-brute.nse
@@ -79,14 +79,11 @@ Driver =
local function getDiscoveredRepos(host)
- if ( not(nmap.registry.cvs) or
- not(nmap.registry.cvs[host.ip]) or
- not(nmap.registry.cvs[host.ip].repos)
- ) then
+ if ( not(host.registry.cvs_repos)) then
return
end
- return nmap.registry.cvs[host.ip].repos
+ return host.registry.cvs_repos
end
action = function(host, port)
diff --git a/scripts/nbstat.nse b/scripts/nbstat.nse
index b9b7a2cee..c94372636 100644
--- a/scripts/nbstat.nse
+++ b/scripts/nbstat.nse
@@ -80,22 +80,22 @@ action = function(host)
-- Get the list of NetBIOS names
- status, names, statistics = netbios.do_nbstat(host.ip)
- status, names, statistics = netbios.do_nbstat(host.ip)
- status, names, statistics = netbios.do_nbstat(host.ip)
- status, names, statistics = netbios.do_nbstat(host.ip)
+ status, names, statistics = netbios.do_nbstat(host)
+ status, names, statistics = netbios.do_nbstat(host)
+ status, names, statistics = netbios.do_nbstat(host)
+ status, names, statistics = netbios.do_nbstat(host)
if(status == false) then
return stdnse.format_output(false, names)
end
-- Get the server name
- status, server_name = netbios.get_server_name(host.ip, names)
+ status, server_name = netbios.get_server_name(host, names)
if(status == false) then
return stdnse.format_output(false, server_name)
end
-- Get the logged in user
- status, user_name = netbios.get_user_name(host.ip, names)
+ status, user_name = netbios.get_user_name(host, names)
if(status == false) then
return stdnse.format_output(false, user_name)
end
diff --git a/scripts/path-mtu.nse b/scripts/path-mtu.nse
index cd7cfd98f..89eb40af0 100644
--- a/scripts/path-mtu.nse
+++ b/scripts/path-mtu.nse
@@ -261,10 +261,7 @@ end
-- Sets necessary probe data in registry
local setreg = function(host, proto, port)
- if not nmap.registry[host.ip] then
- nmap.registry[host.ip] = {}
- end
- nmap.registry[host.ip]['pathmtuprobe'] = {
+ host.registry['pathmtuprobe'] = {
['proto'] = proto,
['port'] = port
}
@@ -301,8 +298,8 @@ action = function(host)
local mtuset
local sock = nmap.new_dnet()
local pcap = nmap.new_socket()
- local proto = nmap.registry[host.ip]['pathmtuprobe']['proto']
- local port = nmap.registry[host.ip]['pathmtuprobe']['port']
+ local proto = host.registry['pathmtuprobe']['proto']
+ local port = host.registry['pathmtuprobe']['port']
local saddr = packet.toip(host.bin_ip_src)
local daddr = packet.toip(host.bin_ip)
local try = nmap.new_try()
diff --git a/scripts/snmp-interfaces.nse b/scripts/snmp-interfaces.nse
index 83e197622..9a5004d56 100644
--- a/scripts/snmp-interfaces.nse
+++ b/scripts/snmp-interfaces.nse
@@ -45,6 +45,7 @@ dependencies = {"snmp-brute"}
-- Revised 04/11/2010 - v0.2 - moved snmp_walk to snmp library
-- Revised 08/10/2010 - v0.3 - prerule; add interface addresses to Nmap's target list (Kris Katterjohn)
-- Revised 05/27/2011 - v0.4 - action; add MAC addresses to nmap.registry[host.ip]["mac-geolocation"] (Gorjan Petrovski)
+-- Revised 07/31/2012 - v0.5 - action; remove mac-geolocation changes (script removed from trunk)
@@ -419,14 +420,6 @@ action = function(host, port)
srvport = port.number
end
- -- table for mac-geolocation.nse
- if not nmap.registry[srvhost] then
- nmap.registry[srvhost] = {}
- nmap.registry[srvhost]["mac-geolocation"] = {}
- elseif not nmap.registry[srvhost]["mac-geolocation"] then
- nmap.registry[srvhost]["mac-geolocation"] = {}
- end
-
socket:set_timeout(5000)
try(socket:connect(srvhost, srvport, "udp"))
@@ -453,14 +446,6 @@ action = function(host, port)
end
local output = stdnse.format_output( true, build_results(interfaces) )
-
- -- insert the MAC addresses into the mac-geolocation table
- for _,item in ipairs(interfaces) do
- if item.phys_addr then
- table.insert(nmap.registry[srvhost]["mac-geolocation"], item.phys_addr:match("^(%x+:%x+:%x+:%x+:%x+:%x+)"))
- end
- end
- -- wtf is this? table.insert(nmap.registry[srvhost]["mac-geolocation"], "00:23:69:2a:b1:27")
if SCRIPT_TYPE == "prerule" and target.ALLOW_NEW_TARGETS then
local sum = 0