PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-10 09:49:05 +00:00
Code Issues Projects Releases Wiki Activity

Improve string representation of DNS query in debug output

Browse Source
This commit is contained in:
dmiller
2024-05-13 14:31:34 +00:00
parent e1a2577ffd
commit 37e0f7f80b
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
nmap_dns.cc
View File

@@ -1823,8 +1823,10 @@ size_t DNS::Packet::parseFromBuffer(const u8 *buf, size_t maxlen)
return ret; return ret;
} }
const char *DNS::Request::repr() const char *DNS::Request::repr() const
{ {
#define REPR_BUFSIZE (FQDN_LEN + 16)
static char buf[REPR_BUFSIZE] = "\0";
switch(type) { switch(type) {
case DNS::NONE: case DNS::NONE:
return "Uninitialized request"; return "Uninitialized request";
@@ -1832,7 +1834,7 @@ const char *DNS::Request::repr()
case DNS::A: case DNS::A:
case DNS::AAAA: case DNS::AAAA:
case DNS::ANY: case DNS::ANY:
return name.c_str(); Snprintf(buf, REPR_BUFSIZE, "%s/%d", name.c_str(), type);
break; break;
case DNS::PTR: case DNS::PTR:
if (ssv.size() > 0) { if (ssv.size() > 0) {
@@ -1843,7 +1845,8 @@ const char *DNS::Request::repr()
} }
break; break;
default: default:
return "Invalid request"; Snprintf(buf, REPR_BUFSIZE, "Invalid request: %d", type);
break; break;
} }
return buf;
} }

2
nmap_dns.h
View File

@@ -256,7 +256,7 @@ struct Request
std::string name; std::string name;
void *userdata; void *userdata;
Request() : type(NONE), ssv(), name(), userdata(NULL) {} Request() : type(NONE), ssv(), name(), userdata(NULL) {}
const char *repr(); // string representation const char *repr() const; // string representation
}; };
} }