From 3daeedd6084711da58198dcf14f63c4a9f99098a Mon Sep 17 00:00:00 2001 From: fyodor Date: Tue, 22 Oct 2013 00:51:58 +0000 Subject: [PATCH] Minor rewording for clarity that someone suggested --- docs/scripting.xml | 18 +++++++++++++----- scripts/smb-enum-users.nse | 3 +-- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/docs/scripting.xml b/docs/scripting.xml index d53edee47..54fd39c06 100644 --- a/docs/scripting.xml +++ b/docs/scripting.xml @@ -307,7 +307,11 @@ Black Hat Briefings in 2010. Usefulness - Default scans need to produce valuable and actionable information. If even the script author has trouble explaining why an average networking or security professional would find the output valuable, the script should not run by default. The script may still be worth including in Nmap so that administrators can run for those occasions when they do need the extra information. + Default scans need to produce valuable and + actionable information. If even the script author has trouble + explaining why an average networking or security professional + would find the output valuable, the script should not run by + default. @@ -319,7 +323,7 @@ Black Hat Briefings in 2010. important information to report, NSE scripts (particularly default ones) should return nothing. Checking for an obscure vulnerability may be OK by default as long as it only produces output - when that vulnerability discovered. + when that vulnerability is discovered. @@ -363,9 +367,13 @@ Black Hat Briefings in 2010. - Scripts in this category may cause denial of service, usually - because they crash a service as a side effect of testing it for a - vulnerability. + Scripts in this category may cause a denial of + service. Sometimes this is done to test vulnerability to + a denial of service method, but more commonly it is + an undesired by necessary side effect of testing for + a traditional vulnerability. These tests sometimes crash + vulnerable services. + diff --git a/scripts/smb-enum-users.nse b/scripts/smb-enum-users.nse index 43222e7b2..95c357d61 100644 --- a/scripts/smb-enum-users.nse +++ b/scripts/smb-enum-users.nse @@ -94,8 +94,7 @@ doesn't hurt to add more. The names and details from both of these techniques are merged and displayed. If the output is verbose, then extra details are shown. The output is ordered alphabetically. -Credit goes out to the enum.exe, sid2user.exe, and user2sid.exe programs. -The code I wrote for this is largely based on the techniques used by them. +Credit goes out to the enum.exe, sid2user.exe, and user2sid.exe programs for pioneering some of the techniques used in this script. ]] ---