1
0
mirror of https://github.com/nmap/nmap.git synced 2025-12-06 04:31:29 +00:00

Remove duplicate test conditionals already tested in enclosing block

This commit is contained in:
dmiller
2020-09-18 18:47:42 +00:00
parent 8ba183531d
commit 4bee1dbfc1

View File

@@ -1993,11 +1993,9 @@ bool HostOsScan::processResp(HostOsScanStats *hss, struct ip *ip, unsigned int l
/* the first reply is used to do T1 */
processT1_7Resp(hss, ip, 0);
}
if (testno < 6) {
/* the 1th~6th replies are used to do TOps and TWin */
processTOpsResp(hss, tcp, testno);
processTWinResp(hss, tcp, testno);
}
/* the 1st NUM_SEQ_SAMPLES replies are used to do TOps and TWin */
processTOpsResp(hss, tcp, testno);
processTWinResp(hss, tcp, testno);
} else if (testno >= NUM_SEQ_SAMPLES && testno < NUM_SEQ_SAMPLES + 6) {
@@ -2025,7 +2023,7 @@ bool HostOsScan::processResp(HostOsScanStats *hss, struct ip *ip, unsigned int l
/* Closed-port TCP IP ID sequence numbers (SEQ.CI). Uses T5, T6, and T7.
T5 starts at NUM_SEQ_SAMPLES + 11. */
if (testno >= NUM_SEQ_SAMPLES + 11 && testno < NUM_SEQ_SAMPLES + 14)
if (testno >= NUM_SEQ_SAMPLES + 11)
hss->ipid.tcp_closed_ipids[testno - (NUM_SEQ_SAMPLES + 11)] = ntohs(ip->ip_id);
}
}