From 4dbc21ff2be71f587f4b6ac750f457cfcc9eb1e0 Mon Sep 17 00:00:00 2001 From: fyodor Date: Mon, 18 May 2009 20:48:17 +0000 Subject: [PATCH] Take some things out of the done category just so that I remember to chat with David about them when he gets back --- docs/TODO | 60 +++++++++++++++++++++++++++---------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/docs/TODO b/docs/TODO index ecb6ec131..85b0e076e 100644 --- a/docs/TODO +++ b/docs/TODO @@ -89,6 +89,36 @@ o We added the SEQ.CI value in Feb 2009 with 0 matchpoints. At some next do fingerprint integration, so we will actually have examples of .CI in the nmap-os-db. [David] +o [NSE] Make it a warning rather than error if a script in script.db + can't be found. [Patrick] + +o [NSE] Correct nsock_connect to unlock the socket slot if the + connection fails. When a socket is closed, it is unlocked so the + arbitrator can potentially open up a socket for another thread. But + Patrick discovered that a socket is not automatically unlocked when + a connection fails or times out, only when it is closed + explicitly. So that could hold up socket allocation for other + threads until garbage collection. May be a cause of slowness or + possibly deadlocks. [Patrick] + +o [NSE] Solve segfault issue which occurs when Nsock events call back + on a thread that has already ended (e.g. timeout, crash, early exit, + whatever) and been garbage collected. May want to just nsi_delete + all nsock sockets immediately upon thread ending. For an example of + this type of segfault, see + http://seclists.org/nmap-dev/2009/q2/0289.html. David says " I think + in the interests of getting this in a stable release, we should use + that strategy of closing all a thread's sockets. That ought to fix + all the problems above. Not to rule out a more thoughtful redesign + in the future." [David,Patrick] + +o [NSE] Get rid of ceil so that floating point NSE runlevels work + again (some scripts, including (smb-brute) rely on this. They got + broken with the NSE core lua rewrite. [David,Patrick]. + +o NSE script logical operator stuff is now documented in + scripting.xml--add to refguide.xml as well. [David/Patrick] + ===FEATURES FOR NEXT STABLE VERSION GO ABOVE THIS POINT=== o We should probably check for a system Lua in a "lua5.1" directory @@ -576,36 +606,6 @@ o random tip database DONE: -o [NSE] Correct nsock_connect to unlock the socket slot if the - connection fails. When a socket is closed, it is unlocked so the - arbitrator can potentially open up a socket for another thread. But - Patrick discovered that a socket is not automatically unlocked when - a connection fails or times out, only when it is closed - explicitly. So that could hold up socket allocation for other - threads until garbage collection. May be a cause of slowness or - possibly deadlocks. [Patrick] - -o [NSE] Solve segfault issue which occurs when Nsock events call back - on a thread that has already ended (e.g. timeout, crash, early exit, - whatever) and been garbage collected. May want to just nsi_delete - all nsock sockets immediately upon thread ending. For an example of - this type of segfault, see - http://seclists.org/nmap-dev/2009/q2/0289.html. David says " I think - in the interests of getting this in a stable release, we should use - that strategy of closing all a thread's sockets. That ought to fix - all the problems above. Not to rule out a more thoughtful redesign - in the future." [David,Patrick] - -o [NSE] Make it a warning rather than error if a script in script.db - can't be found. [Patrick] - -o [NSE] Get rid of ceil so that floating point NSE runlevels work - again (some scripts, including (smb-brute) rely on this. They got - broken with the NSE core lua rewrite. [David,Patrick]. - -o NSE script logical operator stuff is now documented in - scripting.xml--add to refguide.xml as well. [David/Patrick] - o Change Nmap signature files to use the .sig extension rather than .gpg.txt, as that seems to be what gpg recommends. In fact, gpg will automatically verify the right file if it exists after dropping