PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-14 11:49:01 +00:00
Code Issues Projects Releases Wiki Activity

Apply PEP 8 style guidance to zenmap

Browse Source 
Using the pep8 tool (https://pypi.python.org/pypi/pep8), fixed the
following style issues:

Count   Issue
11      E201 whitespace after '['
8       E203 whitespace before ','
41      E211 whitespace before '('
11      E221 multiple spaces before operator
61      E225 missing whitespace around operator
237     E231 missing whitespace after ':'
91      E251 no spaces around keyword / parameter equals
19      E261 at least two spaces before inline comment
41      E301 expected 1 blank line, found 0
200     E302 expected 2 blank lines, found 1
356     E303 too many blank lines (2)
563     E501 line too long (106 characters)
39      E701 multiple statements on one line (colon)
13      E702 multiple statements on one line (semicolon)
4       W291 trailing whitespace
2       W293 blank line contains whitespace
8       W391 blank line at end of file
21      W601 .has_key() is deprecated, use 'in'
2       W602 deprecated form of raising exception

The remaining issues are long lines due to very deep data structures. I
chose not to alter them, as it would involve backslash-continuation
where whitespace is not permitted:

./zenmapGUI/ScanInterface.py:323:80: E501 line too long (90 characters)
./zenmapGUI/ScanInterface.py:456:80: E501 line too long (84 characters)
./zenmapGUI/ScanInterface.py:464:80: E501 line too long (84 characters)
./zenmapGUI/ScanInterface.py:472:80: E501 line too long (122 characters)
./zenmapGUI/ScanInterface.py:479:80: E501 line too long (122 characters)
./zenmapGUI/ScanInterface.py:920:80: E501 line too long (94 characters)
./zenmapGUI/ScanInterface.py:923:80: E501 line too long (93 characters)
./zenmapGUI/MainWindow.py:575:80: E501 line too long (99 characters)
./zenmapGUI/MainWindow.py:906:80: E501 line too long (99 characters)
This commit is contained in:
dmiller
2014-01-08 19:50:22 +00:00
parent 9210a7f1fa
commit 5c662fffdc
100 changed files with 2287 additions and 1814 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
zenmap/radialnet/gui/HostsViewer.py
View File

@@ -138,7 +138,6 @@ DIMENSION = (700, 400)
IP_RE = '^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$'
class HostsViewer(BWMainWindow):
"""
"""
@@ -155,7 +154,6 @@ class HostsViewer(BWMainWindow):
self.__create_widgets()
def __create_widgets(self):
"""
"""
@@ -170,8 +168,6 @@ class HostsViewer(BWMainWindow):
self.add(self.__panel)
def change_notebook(self, node):
"""
"""
@@ -187,7 +183,6 @@ class HostsViewer(BWMainWindow):
self.__panel.add2(self.__view)
class HostsList(gtk.ScrolledWindow):
"""
"""
@@ -203,7 +198,6 @@ class HostsList(gtk.ScrolledWindow):
self.__create_widgets()
def __create_widgets(self):
"""
"""
@@ -239,16 +233,16 @@ class HostsList(gtk.ScrolledWindow):
column = gtk.TreeViewColumn(HOSTS_HEADER[i],
self.__cell,
text = i)
text=i)
self.__hosts_column.append(column)
self.__hosts_column[i].set_reorderable(True)
self.__hosts_column[i].set_resizable(True)
self.__hosts_column[i].set_attributes(self.__cell,
text = i,
background = 3,
editable = 4)
text=i,
background=3,
editable=4)
self.__hosts_treeview.append_column(self.__hosts_column[2])
@@ -262,7 +256,6 @@ class HostsList(gtk.ScrolledWindow):
self.__hosts_treeview.set_cursor((0,))
self.__cursor_callback(self.__hosts_treeview)
def __cursor_callback(self, widget):
"""
"""
@@ -276,7 +269,6 @@ class HostsList(gtk.ScrolledWindow):
self.__parent.change_notebook(node)
def __host_sort(self, treemodel, iter1, iter2):
"""
"""