From 6814bc4cddcac61791a6e11fcb96b2af57002660 Mon Sep 17 00:00:00 2001 From: nnposter Date: Sun, 12 Nov 2023 23:02:33 +0000 Subject: [PATCH] Correct packet size testing in KNX scripts. Fixes #2727, fixes #2728 --- CHANGELOG | 2 ++ scripts/knx-gateway-discover.nse | 2 +- scripts/knx-gateway-info.nse | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 4af8a827c..13c0b464f 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -6,6 +6,8 @@ o Fixed an issue where TCP Connect scan (-sT) on Windows would fail to open any o [NSE] Fixed DNS TXT record parsing which caused asn-query to fail in Nmap 7.80 and later. [David Fifield, Mike Pattrick] +o [NSE][GH#2727][GH#2728] Fixed packet size testing in KNX scripts [f0rw4rd] + Nmap 7.94 [2023-05-19] o Zenmap and Ndiff now use Python 3! Thanks to the many contributors who made diff --git a/scripts/knx-gateway-discover.nse b/scripts/knx-gateway-discover.nse index 7446cbd54..40ec54605 100644 --- a/scripts/knx-gateway-discover.nse +++ b/scripts/knx-gateway-discover.nse @@ -93,7 +93,7 @@ local knxParseSearchResponse = function(ips, results, knxMessage) end local message_format = '>B c1 c4 I2 BBB c1 I2 c2 c6 c4 c6 c30 BB' - if #knxMessage - pos + 1 < string.packlen(message_format) then + if #knxMessage - pos + 1 < string.packsize(message_format) then stdnse.debug1("Message too short for KNX message") return end diff --git a/scripts/knx-gateway-info.nse b/scripts/knx-gateway-info.nse index c59f1ee57..a4d0fe3b2 100644 --- a/scripts/knx-gateway-info.nse +++ b/scripts/knx-gateway-info.nse @@ -56,7 +56,7 @@ local knxParseDescriptionResponse = function(knxMessage) end local message_format = '>BBB c1 I2 c2 c6 c4 c6 c30 BB' - if #knxMessage - pos + 1 < string.packlen(message_format) then + if #knxMessage - pos + 1 < string.packsize(message_format) then stdnse.debug1("Message too short for KNX message") return end