From 6a73f6c94a17a2256e7efe7d0d870a6885ae5cb3 Mon Sep 17 00:00:00 2001
From: david <david@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Tue, 3 May 2011 09:04:41 +0000
Subject: [PATCH] Feature creeper task: make portreasons code better.

---
 todo/nmap.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/todo/nmap.txt b/todo/nmap.txt
index 01e65a523..1bf9b12e8 100644
--- a/todo/nmap.txt
+++ b/todo/nmap.txt
@@ -31,6 +31,15 @@ o Script review:
   - Outlook web address. http://seclists.org/nmap-dev/2011/q2/296.
 
 o Summer of Code feature creeper:
+  o Rewrite the portreasons code not to use parallel arrays
+    (reason_text, reason_pl_text) and not to require special alignment
+    between the enum codes and (for example) ICMP types. Instead
+    define one structure containing all relevant information about a
+    reason, and define helper functions to map ICMP types to reason
+    codes. In particular, code like this needs to go away:
+      current_reason = ping->type + ER_ICMPTYPE_MOD;
+      if (current_reason == ER_DESTUNREACH)
+        current_reason = ping->code + ER_ICMPCODE_MOD;
   o Change Zenmap bug reporter so that instead of an automatic
     submission system, we print a stack trace and request that the user
     send a bug report to nmap-dev.