PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-10 09:49:05 +00:00
Code Issues Projects Releases Wiki Activity

Fix bad output when rmi.Registry.list fails. Closes #262

Browse Source
This commit is contained in:
dmiller
2015-12-19 18:01:11 +00:00
parent 5243f4f049
commit 82b765f6fe
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
scripts/rmi-dumpregistry.nse
View File

@@ -6,7 +6,8 @@ local string = require "string"
local table = require "table" local table = require "table"
description = [[ description = [[
Connects to a remote RMI registry and attempts to dump all of its objects. Connects to a remote RMI registry and attempts to dump all of its
objects.
First it tries to determine the names of all objects bound in the First it tries to determine the names of all objects bound in the
registry, and then it tries to determine information about the registry, and then it tries to determine information about the
@@ -19,7 +20,8 @@ on it.
It also gives information about where the objects are located, (marked It also gives information about where the objects are located, (marked
with @<ip>:port in the output). with @<ip>:port in the output).
Some apps give away the classpath, which this scripts catches in so-called "Custom data". Some apps give away the classpath, which this scripts catches in
so-called "Custom data".
]] ]]
--- ---
@@ -181,7 +183,7 @@ end
-- @return title, data -- @return title, data
function customDataFormatter(className, customData) function customDataFormatter(className, customData)
if customData == nil then return nil end if customData == nil then return nil end
if #customData ==0 then return nil end if #customData == 0 then return nil end
local retData = {} local retData = {}
for k,v in ipairs(customData) do for k,v in ipairs(customData) do
@@ -200,18 +202,17 @@ end
function action(host,port, args) function action(host,port, args)
local registry = rmi.Registry:new( host, port )
local registry= rmi.Registry:new( host, port )
local status, j_array = registry:list() local status, j_array = registry:list()
local output = {} local output = {}
if not status then if not status then
return false, ("Registry listing failed (%s)"):format(tostring(j_array)) table.insert(output, ("Registry listing failed (%s)"):format(tostring(j_array)))
return stdnse.format_output(false, output)
end end
-- It's definitely RMI! -- It's definitely RMI!
port.version.name ='java-rmi' port.version.name = 'java-rmi'
port.version.product='Java RMI Registry' port.version.product = 'Java RMI Registry'
nmap.set_port_version(host,port) nmap.set_port_version(host,port)
-- Monkey patch the java-class in rmi, to set our own custom data formatter -- Monkey patch the java-class in rmi, to set our own custom data formatter
@@ -224,13 +225,12 @@ function action(host,port, args)
--print(data) --print(data)
table.insert(output, name) table.insert(output, name)
dbg("Querying object %s", name) dbg("Querying object %s", name)
local status, j_object= registry:lookup(name) local status, j_object = registry:lookup(name)
if status then if status then
table.insert(output, j_object:toTable()) table.insert(output, j_object:toTable())
end end
end end
return stdnse.format_output(true, output) return stdnse.format_output(true, output)
end end