PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-09 14:11:29 +00:00
Code Issues Projects Releases Wiki Activity

Fix some LGTM.com findings related to type widths

Browse Source
This commit is contained in:
dmiller
2019-12-20 21:51:01 +00:00
parent e356ad1123
commit 87a92c969f
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libnetutil/UDPHeader.cc
View File

@@ -343,7 +343,7 @@ int UDPHeader::setTotalLength(){
* only carry 65,507 or 65,527. However, we are not taking that into account * only carry 65,507 or 65,527. However, we are not taking that into account
* here because UDP is supposed to be independent of IPv4, IPv6 or * here because UDP is supposed to be independent of IPv4, IPv6 or
* whatever other network layer protocol is used to carry the UDP datagrams.*/ * whatever other network layer protocol is used to carry the UDP datagrams.*/
if ((mylen+otherslen) > 65535 || (mylen+otherslen)<8 ){ if (otherslen < 0 || otherslen > 65535 || (mylen+otherslen) > 65535){
printf("UDPHeader::setTotalLength(): Invalid length.\n"); printf("UDPHeader::setTotalLength(): Invalid length.\n");
return OP_FAILURE; return OP_FAILURE;
} }

1
payload.cc
View File

@@ -216,6 +216,7 @@ static unsigned short *parse_portlist(const char *portlist, unsigned int *count)
return NULL; return NULL;
} }
assert(*count < 65536);
result = (unsigned short *) malloc(sizeof(*result) * *count); result = (unsigned short *) malloc(sizeof(*result) * *count);
if (result == NULL) if (result == NULL)
return NULL; return NULL;

2
utils.cc
View File

@@ -215,7 +215,7 @@ void genfry(unsigned char *arr, int elem_sz, int num_elem) {
unsigned short *sptr; unsigned short *sptr;
unsigned int *iptr; unsigned int *iptr;
unsigned char *tmp; unsigned char *tmp;
int bpe; size_t bpe;
if (sizeof(unsigned char) != 1) if (sizeof(unsigned char) != 1)
fatal("%s() requires 1 byte chars", __func__); fatal("%s() requires 1 byte chars", __func__);