1
0
mirror of https://github.com/nmap/nmap.git synced 2025-12-07 13:11:28 +00:00

More corrections of mssql.Helper.GetDiscoveredInstances() always returning a table. Closes #2784

This commit is contained in:
nnposter
2024-07-04 19:44:51 +00:00
parent 596f9c0fe0
commit a0d24d0518
2 changed files with 7 additions and 5 deletions

View File

@@ -13,6 +13,8 @@ o [GH#1451] Nmap now performs forward DNS lookups in parallel, using the same
took just over an hour. The previous system took 49 hours for the same data took just over an hour. The previous system took 49 hours for the same data
set! [Daniel Miller] set! [Daniel Miller]
o [GH#2784] Various bug fixes in the mssql NSE library [johnjaylward, nnposter]
Nmap 7.95 [2024-04-23] Nmap 7.95 [2024-04-23]
o Integrated over 4,000 of your IPv4 OS fingerprints. Added 336 signatures, o Integrated over 4,000 of your IPv4 OS fingerprints. Added 336 signatures,

View File

@@ -2740,9 +2740,9 @@ Helper =
DiscoverByTcp = function( host, port ) DiscoverByTcp = function( host, port )
local version, instance, status local version, instance, status
-- Check to see if we've already discovered an instance on this port -- Check to see if we've already discovered an instance on this port
local instance = Helper.GetDiscoveredInstances(host, port) local instances = Helper.GetDiscoveredInstances(host, port)
if instance then if instances then
return true, {instance} return true, instances
end end
instance = SqlServerInstanceInfo:new() instance = SqlServerInstanceInfo:new()
instance.host = host instance.host = host
@@ -3227,8 +3227,8 @@ Helper =
Helper.Discover( host ) Helper.Discover( host )
if ( port ) then if ( port ) then
local status, instances = Helper.GetDiscoveredInstances(host, port) local instances = Helper.GetDiscoveredInstances(host, port)
if status then if instances then
return true, instances return true, instances
else else
return false, "No SQL Server instance detected on this port" return false, "No SQL Server instance detected on this port"