From ad7b6e416be23890c2d2c6d16cf2918776b4ddf8 Mon Sep 17 00:00:00 2001 From: kris Date: Fri, 16 Nov 2007 03:27:30 +0000 Subject: [PATCH] This isn't fixing a bug; Coverity (CID 27) flagged this so I looked, and it doesn't make sense. Coverity saw that 'received' was tested again NULL, but was dereferenced afterwards with no check. So it should either be checked later, or not checked at all. Following timing.cc, and the fact that it isn't passed NULL anywhere, and because it doesn't make sense to pass 'adjustTimeouts' nothing to work with, I've just removed the check. Yeah, this log message is way longer than the patch is :). --- traceroute.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/traceroute.cc b/traceroute.cc index 6ae05bcc8..4dcd02c72 100644 --- a/traceroute.cc +++ b/traceroute.cc @@ -1370,8 +1370,7 @@ void TimeInfo::adjustTimeouts (struct timeval *received, u16 scan_delay) { long delta = 0; - if (received) - recvTime = *received; + recvTime = *received; if (o.debugging > 3) { log_write (LOG_STDOUT, "Timeout vals: srtt: %d rttvar: %d to: %d ", to.srtt, to.rttvar,