From ae17eba3c3bc44e74ba6355b7a7ece753daabd20 Mon Sep 17 00:00:00 2001
From: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Thu, 12 Nov 2015 20:01:53 +0000
Subject: [PATCH] Fix failure to build on Windows: need different approach if
 any

---
 ncat/ncat_listen.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/ncat/ncat_listen.c b/ncat/ncat_listen.c
index 1dd0fd82d..f0dfc9bf4 100644
--- a/ncat/ncat_listen.c
+++ b/ncat/ncat_listen.c
@@ -260,22 +260,21 @@ static int ncat_listen_stream(int proto)
         setup_ssl_listen();
 #endif
 
+/* Not sure if this problem exists on Windows, but fcntl and /dev/null don't */
+#ifndef WIN32
     /* Check whether stdin is closed. Because we treat this fd specially, we
      * can't risk it being reopened for an incoming connection, so we'll hold
      * it open instead. */
     if (fcntl(STDIN_FILENO, F_GETFD) == -1 && errno == EBADF) {
       logdebug("stdin is closed, attempting to reserve STDIN_FILENO\n");
-#ifdef WIN32
-      rc = open("NUL", O_RDONLY);
-#else
       rc = open("/dev/null", O_RDONLY);
-#endif
       if (rc >= 0 && rc != STDIN_FILENO) {
         /* Oh well, we tried */
         logdebug("Couldn't reserve STDIN_FILENO\n");
         close(rc);
       }
     }
+#endif
 
     /* We need a list of fds to keep current fdmax. The second parameter is a
        number added to the supplied connection limit, that will compensate
@@ -690,22 +689,21 @@ static int ncat_listen_dgram(int proto)
     Signal(SIGPIPE, SIG_IGN);
 #endif
 
+/* Not sure if this problem exists on Windows, but fcntl and /dev/null don't */
+#ifndef WIN32
     /* Check whether stdin is closed. Because we treat this fd specially, we
      * can't risk it being reopened for an incoming connection, so we'll hold
      * it open instead. */
     if (fcntl(STDIN_FILENO, F_GETFD) == -1 && errno == EBADF) {
       logdebug("stdin is closed, attempting to reserve STDIN_FILENO\n");
-#ifdef WIN32
-      i = open("NUL", O_RDONLY);
-#else
       i = open("/dev/null", O_RDONLY);
-#endif
       if (i >= 0 && i != STDIN_FILENO) {
         /* Oh well, we tried */
         logdebug("Couldn't reserve STDIN_FILENO\n");
         close(i);
       }
     }
+#endif
 
     /* set for selecting udp listening sockets */
     fd_set listen_fds;