From aeae42ddc36f5165980910ad7ecdbc38487450c2 Mon Sep 17 00:00:00 2001
From: david <david@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Thu, 30 Oct 2008 22:06:37 +0000
Subject: [PATCH] Add an assertion that l_get_dns_servers doesn't return any
 DNS servers is !o.mass_dns. Simplify the loop that builds the server list.

---
 nmap_dns.cc | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/nmap_dns.cc b/nmap_dns.cc
index 2ab607d41..13c264ff7 100644
--- a/nmap_dns.cc
+++ b/nmap_dns.cc
@@ -1345,12 +1345,15 @@ std::list<std::string> get_dns_servers() {
   if(servs.size() == 0 && firstrun) {
     nmap_mass_rdns(NULL, 0);
   }
+
+  // If the user said --system-dns (!o.mass_dns), we should never return a list
+  // of servers.
+  assert(o.mass_dns || servs.empty());
+
   std::list<dns_server *>::iterator servI;
   std::list<std::string> serverList;
-  dns_server *tpserv;
-  for(servI = servs.begin(); servI != servs.end(); servI++) {
-    tpserv = *servI;
-    serverList.push_back(inet_ntoa(tpserv->addr.sin_addr));
-  }
+  for(servI = servs.begin(); servI != servs.end(); servI++)
+    serverList.push_back(inet_ntoa((*servI)->addr.sin_addr));
+
   return serverList;
 }