PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2025-12-06 04:31:29 +00:00
Code Issues Projects Releases Wiki Activity

Change a FIXME to a TODO with documentation of related issues #180 and #1407

Browse Source
This commit is contained in:
dmiller
2020-01-14 03:39:25 +00:00
parent 7faec7f157
commit b03c96c326
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libnetutil/netutil.cc
View File

@@ -4335,11 +4335,12 @@ int read_reply_pcap(pcap_t *pd, long to_usec,
return 0; return 0;
if (rcvdtime) { if (rcvdtime) {
// FIXME: I eventually need to figure out why Windows head.ts time is sometimes BEFORE the time I // TODO: come up with a better way to synchronize pcap with gettimeofday.
// sent the packet (which is according to gettimeofday() in nbase). For now, I will sadly have to // Npcap and WinPcap both suffer from clock drift relative to gettimeofday().
// use gettimeofday() for Windows in this case // We hope to fix this with better time sources for Npcap ( http://issues.nmap.org/1407 )
// Actually I now allow .05 discrepancy. So maybe this isn't needed. I'll comment out for now. // and for Nmap ( http://issues.nmap.org/180 )
// Nope: it is still needed at least for Windows. Sometimes the time from he pcap header is a // For now, we use gettimeofday() for Windows in this case.
// Sometimes the time from the pcap header is a
// COUPLE SECONDS before the gettimeofday() results :(. // COUPLE SECONDS before the gettimeofday() results :(.
#if defined(WIN32) || defined(__amigaos__) #if defined(WIN32) || defined(__amigaos__)
gettimeofday(&tv_end, NULL); gettimeofday(&tv_end, NULL);