PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-01-22 22:29:03 +00:00
Code Issues Projects Releases Wiki Activity

Replace key existence tests with dict.get()

Browse Source 
Replaced instances of this pattern:

if 'key' in somedict:
    var = somedict['key']
else:
    var = ""

...with this much simpler pattern:

var = somedict.get('key', "")

Some variations, like returning None if the key is not found were also
replaced.
This commit is contained in:
dmiller
2014-01-08 20:28:12 +00:00
parent 5c662fffdc
commit b254234118
5 changed files with 10 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
zenmap/zenmapGUI/ProfileHelp.py
View File

@@ -137,28 +137,19 @@ class ProfileHelp:
self.labels[option_name] = text
def get_label(self):
if self.currentstate in self.labels.keys():
return self.labels[self.currentstate]
else:
return "" # blank
return self.labels.get(self.currentstate, "")
def add_shortdesc(self, option_name, text):
self.descs[option_name] = text
def get_shortdesc(self):
if self.currentstate in self.descs.keys():
return self.descs[self.currentstate]
else:
return "" # blank
return self.descs.get(self.currentstate, "")
def add_example(self, option_name, text):
self.examples[option_name] = text
def get_example(self):
if self.currentstate in self.examples.keys():
return self.examples[self.currentstate]
else:
return "" # blank
return self.examples.get(self.currentstate, "")
def handler(self, whichLabel):
log.debug("whichLabel: %s" % whichLabel)