From be0714006fed72d95341460f7d44c562e7373636 Mon Sep 17 00:00:00 2001 From: david Date: Fri, 21 May 2010 00:29:21 +0000 Subject: [PATCH] Add to todo/nping.txt: * Replace this pattern: if ( isNumber_u32(optarg) ){ u32 aux32 = strtoul( optarg, NULL, 10); ... } with a function that checks for syntax and returns the value (i.e., a wrapper around strtoul). There is nowhere that isNumber_u* is called without it being immediately followed by a strtoul, outside of utils.cc. --- todo/nping.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/todo/nping.txt b/todo/nping.txt index 00fc050c4..bfc485d54 100644 --- a/todo/nping.txt +++ b/todo/nping.txt @@ -197,6 +197,15 @@ + If you wish to contribute code to Nping there is a TO-DO list you can have + a look at (file "todo/nping.txt" in nmap's source package). +* Replace this pattern: + if ( isNumber_u32(optarg) ){ + u32 aux32 = strtoul( optarg, NULL, 10); + ... + } + with a function that checks for syntax and returns the value (i.e., a wrapper + around strtoul). There is nowhere that isNumber_u* is called without it being + immediately followed by a strtoul, outside of utils.cc. + /***************************************************************************** * Things that have been solved already * *****************************************************************************/