mirror of
https://github.com/nmap/nmap.git
synced 2025-12-24 00:19:01 +00:00
Fix error:
SCRIPT ENGINE (506.424s): ./scripts/pop3-capabilities.nse against a.b.1.47:995 ended with error: ./scripts/pop3-capabilities.nse:32: bad argument #1 to 'pairs' (table expected, got string) which happens because pop3.lua returns a string error message instead of a table of capabilities if it can't connect the socket or obtain a response from a connected socket. It now returns nil, err_message in these cases and the documentation now reflects this - pop3-capabilities.nse silently returns and prints a debug message. Added a 10s timeout for the socket in pop3.lua capabilities - 30s was a bit much.
This commit is contained in:
@@ -24,8 +24,8 @@ require 'stdnse'
|
||||
portrule = shortport.port_or_service({110}, "pop3")
|
||||
|
||||
action = function(host, port)
|
||||
local capa = pop3.capabilities(host, port)
|
||||
if capa then
|
||||
local capa, err = pop3.capabilities(host, port)
|
||||
if type(capa) == "table" then
|
||||
-- Convert the capabilities table into an array of strings.
|
||||
local capstrings = {}
|
||||
local cap, args
|
||||
@@ -43,6 +43,9 @@ action = function(host, port)
|
||||
table.insert(capstrings, capstr)
|
||||
end
|
||||
return stdnse.strjoin(" ", capstrings)
|
||||
elseif type(err) == "string" then
|
||||
stdnse.print_debug(1, "%s: '%s' for %s", filename, err, host.ip)
|
||||
return
|
||||
else
|
||||
return "server doesn't support CAPA"
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user