Avoid 'import *' where __all__ not defined. #1834

zenmap/zenmapGUI/MainWindow.py

@@ -144,7 +144,9 @@ from zenmapGUI.higwidgets.higlabels import HIGEntryLabel
 from zenmapGUI.higwidgets.higboxes import HIGHBox, HIGVBox
 
 import zenmapGUI.App
-from zenmapGUI.FileChoosers import *
+from zenmapGUI.FileChoosers import RESPONSE_OPEN_DIRECTORY, \
+        ResultsFileChooserDialog, SaveResultsFileChooserDialog, \
+        SaveToDirectoryChooserDialog
 from zenmapGUI.ScanInterface import ScanInterface
 from zenmapGUI.ProfileEditor import ProfileEditor
 from zenmapGUI.About import About

zenmap/zenmapGUI/OptionBuilder.py

@@ -144,7 +144,7 @@ from zenmapGUI.ProfileHelp import ProfileHelp
 
 from zenmapCore.NmapOptions import NmapOptions, split_quoted, join_quoted
 import zenmapCore.I18N  # lgtm[py/unused-import]
-from zenmapGUI.ScriptInterface import *
+from zenmapGUI.ScriptInterface import ScriptInterface
 
 
 def get_option_check_auxiliary_widget(option, ops, check):

zenmap/zenmapGUI/ProfileEditor.py

@@ -137,7 +137,7 @@ from zenmapGUI.higwidgets.higtextviewers import HIGTextView
 from zenmapGUI.higwidgets.higbuttons import HIGButton
 from zenmapGUI.higwidgets.higtables import HIGTable
 from zenmapGUI.higwidgets.higdialogs import HIGAlertDialog, HIGDialog
-from zenmapGUI.OptionBuilder import *
+from zenmapGUI.OptionBuilder import OptionBuilder
 from zenmapCore.Paths import Path
 from zenmapCore.UmitConf import CommandProfile
 from zenmapCore.UmitLogging import log

zenmap/zenmapGUI/ScriptInterface.py

@@ -141,7 +141,7 @@ import xml.sax
 from zenmapGUI.higwidgets.higboxes import HIGVBox, HIGHBox
 from zenmapGUI.higwidgets.higscrollers import HIGScrolledWindow
 from zenmapGUI.higwidgets.higbuttons import HIGButton
-from zenmapCore.ScriptMetadata import *
+from zenmapCore.ScriptMetadata import get_script_entries
 from zenmapCore.ScriptArgsParser import parse_script_args_dict
 from zenmapCore.NmapCommand import NmapCommand
 from zenmapCore.NmapOptions import NmapOptions

zenmap/zenmapGUI/TopologyPage.py

@@ -128,15 +128,11 @@
 
 import gtk
 
-from zenmapGUI.ScanToolbar import *
-
 from zenmapGUI.higwidgets.higboxes import HIGVBox
 
 import radialnet.gui.RadialNet as RadialNet
-from radialnet.gui.ControlWidget import *
+from radialnet.gui.ControlWidget import ControlWidget, ControlFisheye
 from radialnet.gui.Toolbar import Toolbar
-from radialnet.bestwidgets.boxes import *
-from radialnet.bestwidgets.windows import *
 from radialnet.util.integration import make_graph_from_hosts
 
 

zenmap/zenmapGUI/higwidgets/higentries.py

@@ -134,6 +134,8 @@ higwidgets/higentries.py
 
 import gtk
 
+__all__ = ('HIGTextEntry', 'HIGPasswordEntry')
+
 HIGTextEntry = gtk.Entry
 
 

zenmap/zenmapGUI/higwidgets/higwindows.py

@@ -134,6 +134,8 @@ higwidgets/higwindows.py
 
 import gtk
 
+__all__ = ('HIGWindow', 'HIGMainWindow')
+
 
 class HIGWindow(gtk.Window):
     """HIGFied Window"""