1
0
mirror of https://github.com/nmap/nmap.git synced 2025-12-07 13:11:28 +00:00

Replace chained concatenation reassignment with simple concatenation

Example:

x = y
x = x .. z

Fixed:

x = y
.. z

This simple fix would save 1 string creation/deletion. Most changes
involve many more than this.
This commit is contained in:
dmiller
2015-03-02 13:47:42 +00:00
parent 3025022f98
commit ea58c6bebb
12 changed files with 235 additions and 260 deletions

View File

@@ -1903,15 +1903,15 @@ NTAuthenticationPacket = {
local sessionkey_offset = hostname_offset + #hostname
local data = bin.pack("<AISSI", ntlmssp, NTLMSSP_AUTH, #lm_response, #lm_response, lm_response_offset)
data = data .. bin.pack("<SSI", #ntlm_response, #ntlm_response, ntlm_response_offset)
data = data .. bin.pack("<SSI", #domain, #domain, domain_offset)
data = data .. bin.pack("<SSI", #user, #user, username_offset)
data = data .. bin.pack("<SSI", #hostname, #hostname, hostname_offset)
data = data .. bin.pack("<SSI", #sessionkey, #sessionkey, sessionkey_offset)
data = data .. bin.pack("<I", flags)
data = data .. bin.pack("A", domain)
data = data .. bin.pack("A", user )
data = data .. lm_response .. ntlm_response
.. bin.pack("<SSI", #ntlm_response, #ntlm_response, ntlm_response_offset)
.. bin.pack("<SSI", #domain, #domain, domain_offset)
.. bin.pack("<SSI", #user, #user, username_offset)
.. bin.pack("<SSI", #hostname, #hostname, hostname_offset)
.. bin.pack("<SSI", #sessionkey, #sessionkey, sessionkey_offset)
.. bin.pack("<I", flags)
.. bin.pack("A", domain)
.. bin.pack("A", user )
.. lm_response .. ntlm_response
return PacketType.NTAuthentication, data
end,