From ef2825b3bc6d7f8ecf0897ea1c3b0d13261e24b8 Mon Sep 17 00:00:00 2001 From: nnposter Date: Sun, 1 Sep 2019 03:53:04 +0000 Subject: [PATCH] Populate ID Authority with the correct value. See #1720 --- CHANGELOG | 3 +++ nselib/msrpctypes.lua | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index 5b9f82093..87420a650 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,8 @@ #Nmap Changelog ($Id$); -*-text-*- +o [NSE][GH#1720] Function marshall_dom_sid2 in library msrpctypes was not + correctly populating ID Authority. [nnposter] + o [NSE][GH#1720] Unmarshalling functions in library msrpctypes were attempting arithmetic on a nil argument. [Ivan Ivanov, nnposter] diff --git a/nselib/msrpctypes.lua b/nselib/msrpctypes.lua index 8300fac4d..0cc4fea1b 100644 --- a/nselib/msrpctypes.lua +++ b/nselib/msrpctypes.lua @@ -1655,7 +1655,7 @@ function marshall_dom_sid2(sid) result = { -- TODO: Is the first 32-bit integer here supposed to be num_auths, or some -- other count value? - string.pack("I6", sid_array.num_auths, sid_array.sid_rev_num, sid_array.num_auths, sid_array.authority), + string.pack("I6", sid_array.num_auths, sid_array.sid_rev_num, sid_array.num_auths, sid_array.authority_high), } for i = 1, sid_array['num_auths'], 1 do result[#result+1] = string.pack("