From f29a494d2b4e96e90fcb293375034cafea94559b Mon Sep 17 00:00:00 2001 From: jay Date: Tue, 10 Jun 2014 09:15:20 +0000 Subject: [PATCH] Modifying r32985 based on Henri Doreau's comment "For sequences, (strings, lists, tuples), use the fact that empty sequences are false." PEP-0008 says[1]. [1] http://legacy.python.org/dev/peps/pep-0008/ --- zenmap/zenmapGUI/DiffCompare.py | 2 +- zenmap/zenmapGUI/ScanNmapOutputPage.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/zenmap/zenmapGUI/DiffCompare.py b/zenmap/zenmapGUI/DiffCompare.py index e1953dd46..3adc5e7b8 100644 --- a/zenmap/zenmapGUI/DiffCompare.py +++ b/zenmap/zenmapGUI/DiffCompare.py @@ -202,7 +202,7 @@ class ScanChooser(HIGVBox): def show_scan(self, widget): nmap_output = self.get_nmap_output() - if nmap_output != "": + if nmap_output: self.txt_scan_result.get_buffer().set_text(nmap_output) def normalize_output(self, output): diff --git a/zenmap/zenmapGUI/ScanNmapOutputPage.py b/zenmap/zenmapGUI/ScanNmapOutputPage.py index 78d9c1dcf..8f471121a 100644 --- a/zenmap/zenmapGUI/ScanNmapOutputPage.py +++ b/zenmap/zenmapGUI/ScanNmapOutputPage.py @@ -268,7 +268,7 @@ class ScanNmapOutputPage(HIGVBox): if entry.parsed is not None: self.nmap_output.set_command_execution(None) nmap_output = entry.parsed.get_nmap_output() - if nmap_output != "": + if nmap_output: self.nmap_output.show_nmap_output(nmap_output) self.details_button.set_sensitive(True) elif entry.command is not None: