From f2bbe854c8b4c2f9a9421e8fee66276d9db39dff Mon Sep 17 00:00:00 2001 From: david Date: Thu, 12 Feb 2009 17:30:07 +0000 Subject: [PATCH] Use unsigned chars when writing an Ncat hex dump file. On platforms with signed chars, bytes with value above 0x7F were being sign-extended within a three-byte buffer to become FFF. This made output like [0000] 16 03 00 00 53 01 00 00 4F 03 00 3F 47 FFFFFFFFF ....S... O..?G... [0010] 2C FFFFFFFFF60 7E FFF00 FFFFFF7B FFFFFFFFFFFF77 ,...`~.. ..{....w [0020] FFFFFFFFFFFF3C 3D FFF6F FFF10 6E 00 00 28 00 16 ....<=.o ..n..(.. Fixed, it looks like [0000] 16 03 00 00 53 01 00 00 4F 03 00 3F 47 D7 F7 BA ....S... O..?G... [0010] 2C EE EA B2 60 7E F3 00 FD 82 7B B9 D5 96 C8 77 ,...`~.. ..{....w [0020] 9B E6 C4 DB 3C 3D DB 6F EF 10 6E 00 00 28 00 16 ....<=.o ..n..(.. --- CHANGELOG | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 02c07947b..056a73b3f 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,8 @@ # Nmap Changelog ($Id$); -*-text-*- +o [Ncat] An error in formatting bytes with the high bit set in hex dump output + was fixed. [David] + o [Zenmap] New translation: Croatian (contributed by Vlatko Kosturjak). o Fixed a DNS decoding bug in dns-zone-transfer.nse that created