From fa3080e79d9cfdeb3a02db60399e0510ced8d501 Mon Sep 17 00:00:00 2001 From: dmiller Date: Thu, 5 Nov 2015 02:42:36 +0000 Subject: [PATCH] Clarify script args for dns-update.nse --- scripts/dns-update.nse | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/dns-update.nse b/scripts/dns-update.nse index 786664459..798794082 100644 --- a/scripts/dns-update.nse +++ b/scripts/dns-update.nse @@ -6,6 +6,9 @@ local table = require "table" description = [[ Attempts to perform a dynamic DNS update without authentication. + +Either the test or both the hostname and +ip script arguments are required. ]] author = "Patrik Karlsson" @@ -22,8 +25,9 @@ categories = {"vuln", "intrusive"} -- | Successfully added the record "nmap-test.cqure.net" -- |_ Successfully deleted the record "nmap-test.cqure.net" -- --- @args dns-update.hostname the name of the host to add to the zone --- @args dns-update.ip the ip address of the host to add to the zone +-- @args dns-update.hostname The name of the host to add to the zone +-- @args dns-update.ip The ip address of the host to add to the zone +-- @args dns-update.test Add and remove 4 records to determine if the target is vulnerable. -- -- @@ -82,7 +86,9 @@ action = function(host, port) local name, ip = stdnse.get_script_args('dns-update.hostname', 'dns-update.ip') if ( t ) then return test(host, port) end - if ( not(name) or not(ip) ) then return end + if ( not(name) or not(ip) ) then + return stdnse.format_output(false, "Missing required script args: dns-update.hostname and dns-update.ip") + end -- we really need an ip or name to continue -- we could attempt a random name, but we need to know at least the name of the zone