From b7d2680e55b9c93087f1a4f461a4edda9e9773fa Mon Sep 17 00:00:00 2001 From: Bernardo Damele Date: Mon, 2 Jul 2012 12:50:26 +0100 Subject: [PATCH] minor refactoring, issue #51 --- lib/takeover/xp_cmdshell.py | 5 ++--- procs/mssqlserver/disable_xp_cmdshell_2000.txt | 1 + procs/mssqlserver/enable_xp_cmdshell_2000.txt | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 procs/mssqlserver/disable_xp_cmdshell_2000.txt create mode 100644 procs/mssqlserver/enable_xp_cmdshell_2000.txt diff --git a/lib/takeover/xp_cmdshell.py b/lib/takeover/xp_cmdshell.py index d4b9cac86..56743b9ec 100644 --- a/lib/takeover/xp_cmdshell.py +++ b/lib/takeover/xp_cmdshell.py @@ -76,10 +76,9 @@ class xp_cmdshell: logger.debug(debugMsg) if mode == 1: - cmd = "EXEC master..sp_addextendedproc 'xp_cmdshell', " - cmd += "@dllname='xplog70.dll'" + cmd = getSPQLSnippet(DBMS.MSSQL, "enable_xp_cmdshell_2000", ENABLE=str(mode)) else: - cmd = "EXEC master..sp_dropextendedproc 'xp_cmdshell'" + cmd = getSPQLSnippet(DBMS.MSSQL, "disable_xp_cmdshell_2000", ENABLE=str(mode)) return cmd diff --git a/procs/mssqlserver/disable_xp_cmdshell_2000.txt b/procs/mssqlserver/disable_xp_cmdshell_2000.txt new file mode 100644 index 000000000..ae22febdc --- /dev/null +++ b/procs/mssqlserver/disable_xp_cmdshell_2000.txt @@ -0,0 +1 @@ +EXEC master..sp_dropextendedproc 'xp_cmdshell'; diff --git a/procs/mssqlserver/enable_xp_cmdshell_2000.txt b/procs/mssqlserver/enable_xp_cmdshell_2000.txt new file mode 100644 index 000000000..52e1044a7 --- /dev/null +++ b/procs/mssqlserver/enable_xp_cmdshell_2000.txt @@ -0,0 +1 @@ +EXEC master..sp_addextendedproc 'xp_cmdshell', @dllname='xplog70.dll';