PenTest/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-01-19 20:59:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix a test condition in the ICMP response checking code for ping scans. A test

Browse Source 
that should have fired whenever !USI->ptech.rawprotoscan wrongly had the
additional condition && o.debugging, meaning that it worked properly only when
debugging was enabled. See http://seclists.org/nmap-dev/2008/q4/0130.html and
http://seclists.org/nmap-dev/2008/q4/0206.html for problem reports.
This commit is contained in:
david
2008-10-20 16:52:42 +00:00
parent 02d35294c3
commit 5a34d64f8e
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG
View File

@@ -1,5 +1,11 @@
# Nmap Changelog ($Id$); -*-text-*-
o A crash caused by an incorrect test condition was fixed. It would
happen when running a ping scan other than a protocol ping, without
debugging enabled, if an ICMP packet was received referring to a
packet that was not TCP, UDP, or ICMP. Thanks to Brandon Enright and
Matt Castelein for reporting the problem. [David]
o [Zenmap] The keyboard shortcut for "Save to Directory" has been
changed from Ctrl+v to Ctrl+Alt+s so as not to conflict with the
usual paste shortcut [Jah, Michael].

3
scan_engine.cc
View File

@@ -4315,7 +4315,8 @@ static int get_ping_pcap_result(UltraScanInfo *USI, struct timeval *stime) {
/* Did we fail to find a probe? */
if (probenum >= listsz)
continue;
} else if (o.debugging && !USI->ptech.rawprotoscan) {
} else if (!USI->ptech.rawprotoscan) {
if (o.debugging)
error("Got ICMP response to a packet which was not TCP, UDP, or ICMP");
continue;
}