Avoid 'using namespace std' causing name conflicts. Fixes #1363, fixes #1867

CHANGELOG

@@ -1,5 +1,9 @@
 #Nmap Changelog ($Id$); -*-text-*-
 
+o [Nping] Address build failure under libc++ due to "using namespace std;" in
+  several headers, resulting in conflicting definitions of bind(). Reported by
+  StormBytePP and Rosen Penev. [Daniel Miller]
+
 o [Ncat][GH#1868] Fix a fatal error when connecting to a Linux VM socket with
   verbose output enabled. [Stefano Garzarella]
 

nping/EchoServer.cc

@@ -199,7 +199,7 @@ NEPContext *EchoServer::getClientContext(nsock_iod iod){
   * the context could not be found.  */
 int EchoServer::destroyClientContext(clientid_t clnt){
   bool deleted=false;
-  vector<NEPContext>::iterator it;
+  std::vector<NEPContext>::iterator it;
   /* Iterate through the context array and delete the one that belongs to clnt */
   for ( it=this->client_ctx.begin(); it<this->client_ctx.end(); it++){
       if(it->getIdentifier()==clnt){

nping/EchoServer.h

@@ -136,15 +136,13 @@
 #include <vector>
 #include "NEPContext.h"
 
-using namespace std;
-
 #define LISTEN_QUEUE_SIZE 10
 
 class EchoServer  {
 
     private:
         /* Attributes */
-        vector<NEPContext> client_ctx;
+        std::vector<NEPContext> client_ctx;
         clientid_t client_id_count;
 
         /* Methods */

nping/NEPContext.h

@@ -135,7 +135,6 @@
 #include "nsock.h"
 #include "EchoHeader.h"
 #include <vector>
-using namespace std;
 
 /* SERVER STATE MACHINE                                                       */
 /*                      _                                                     */
@@ -204,7 +203,7 @@ class NEPContext {
         u8 client_nonce[NONCE_LEN];
         bool server_nonce_set;
         bool client_nonce_set;
-        vector<fspec_t> fspecs;
+        std::vector<fspec_t> fspecs;
         struct sockaddr_storage clnt_addr;
 
         u8 *generateKey(int key_type, size_t *final_len);

nping/NpingTargets.h

@@ -137,8 +137,6 @@
 #include "NpingTarget.h"
 #include <vector>
 
-using namespace std;
-
 #define MAX_NPING_HOSTNAME_LEN 512    /**< Max length for named hosts */
 
 class NpingTargets {
@@ -176,7 +174,7 @@ class NpingTargets {
 
     /* TODO: Make private */
     NpingTarget *currenths;
-    vector<NpingTarget *> Targets;
+    std::vector<NpingTarget *> Targets;
 
 }; /* End of class NpingTargets */
 

nping/ProbeMode.h

@@ -135,11 +135,9 @@
 
 #include "nping.h"
 #include "nsock.h"
-#include <vector>
 #include "NpingTarget.h"
 #include "utils_net.h"
 #include "utils.h"
-using namespace std;
 
 #define PKT_TYPE_TCP_CONNECT  1
 #define PKT_TYPE_UDP_NORMAL   2

nping/nping.cc

@@ -150,7 +150,6 @@
 #include <signal.h>
 #include <time.h>
 
-using namespace std;
 NpingOps o;
 EchoClient ec;
 EchoServer es;

nping/utils.h

@@ -143,8 +143,6 @@
 #endif
 
 #include "global_structures.h"
-#include <vector>
-using namespace std;
 
 /* Function prototypes */
 bool contains(const char *source, const char *substring);