dmiller
3c7f2de01b
Properly return negative on error from vsnprintf
...
Our implementation of vsnprintf for systems where it is missing did not
correctly return a negative value on error, instead returning the size
passed in. We got this code from tcpdump/libpcap, and it was wrong
there, too, though their latest master branch has removed it in favor of
requiring a C99 compiler (C99 guarantees vsnprintf).
This should remove a LGTM code analysis finding (See #1834 ) of
cpp/constant-comparison in Ncat because we were checking for a negative
return from Snprintf, which would never occur.
2019-12-29 05:53:27 +00:00
dmiller
736cefcdb6
Pass ScriptResult by const reference instead of copying. #1834
2019-12-29 05:15:12 +00:00
dmiller
784142022d
Make destructor virtual (no effect at the moment). #1834
2019-12-29 05:15:11 +00:00
dmiller
5e30d6e29e
Fix loop flow. #1834
2019-12-29 05:15:10 +00:00
dmiller
b74f70fb33
Avoid integer overflow in multiplication. See #1834
2019-12-29 05:15:10 +00:00
dmiller
d5b57a8cd9
Replace ncat's custom hexdump function with the one from nbase.
2019-12-28 20:12:45 +00:00
dmiller
92bf83aaba
Remove unused imports
2019-12-28 02:42:14 +00:00
dmiller
6d624f9ed7
Correct function prototypes from earlier change
2019-12-26 16:46:18 +00:00
dmiller
898988dcd3
Remove dangling else
2019-12-26 16:46:17 +00:00
dmiller
d497aa268e
Instruct LGTM.com to ignore some external libraries.
2019-12-25 20:06:55 +00:00
dmiller
ee32b56ebb
Comment some empty blocks. #1834
2019-12-25 20:01:18 +00:00
dmiller
be0818a664
Use different variable name for local vs param. #1834
2019-12-25 20:01:18 +00:00
dmiller
7d1530476d
Remove some unnecessary/constant comparisons. #1834
2019-12-25 20:01:17 +00:00
dmiller
c155bf1bdc
Be sure to free a strdup'd string in NpingOps destructor. #1834
2019-12-25 20:01:16 +00:00
dmiller
8ad0a33c37
Add header guards to Nping headers. #1834
2019-12-25 20:01:16 +00:00
dmiller
0c2a3776f0
Remove incorrect use of const on return type (not pointer). #1834
2019-12-25 20:01:15 +00:00
dmiller
8192ce2b6c
Avoid using global names as function params. #1834
2019-12-25 20:01:14 +00:00
dmiller
5abe0aa8cc
Combine/simplify conditional branches, eliminating dead code. See #1834
2019-12-22 21:50:55 +00:00
dmiller
61d77a2165
Remove some constant-false conditionals and dead code. See #1834
2019-12-22 21:50:54 +00:00
dmiller
69f1576c17
Fix a LGTM.com finding (false positive, but easier to just change it)
2019-12-22 14:32:05 +00:00
dmiller
bf9b61ad22
Fix comment style for LGTM alert suppression
2019-12-22 14:32:04 +00:00
dmiller
87a92c969f
Fix some LGTM.com findings related to type widths
2019-12-20 21:51:01 +00:00
dmiller
e356ad1123
Add thread-safe wrapper for ctime.
2019-12-20 20:53:32 +00:00
dmiller
20f47dd6f2
Can't use a macro for a declared function (win32)
2019-12-20 20:53:31 +00:00
dmiller
162aa15d25
Delete unreferenced file.
2019-12-20 19:37:40 +00:00
dmiller
6a971163ac
Fix calls to super from old-style classes.
2019-12-20 19:36:48 +00:00
nnposter
ccdb816552
Avoid traversing dot and dot-dot directories
2019-12-19 20:16:23 +00:00
nnposter
6998bfca49
Refactors function smb.find_files()
...
- Replaces its coroutine design to avoid sharing sockets across threads
(Fixes #1837 )
- Corrects conversion of file attributes into bitmask
- Removes side effect of modifying parameter "options" by populating
member "srch_attrs"
- Implements options.maxfiles to take advantage of script arg ls.maxfiles,
reducing file requests that would be ultimately ignored anyway
- Improves performace by supporting larger SMB block sizes
- Implements rudimentary support for Trans2_Data by smb.send_transaction2()
- Adds standard definitions for SMB file attributes
2019-12-19 20:13:16 +00:00
dmiller
1d8ed90a5c
Change from mktemp to mkstemp. Related #1834
2019-12-19 05:27:48 +00:00
dmiller
d0c61b9cbb
Avoid DeprecationWarning due to accessing BaseException.message
2019-12-19 05:25:21 +00:00
dmiller
260fa12cce
Fix up some unused test code to silence LGTM. See #1834
2019-12-16 05:55:46 +00:00
dmiller
fa0353badd
Fix 'Missing call to __init__ during object initialization' from LGTM. See #1834
2019-12-16 05:55:45 +00:00
nnposter
be3d719dd7
Correct a constant value typo
2019-12-15 20:45:54 +00:00
dmiller
4a1c9424d3
Replace localtime calls with thread-safe alternative. See #1834
2019-12-15 05:05:57 +00:00
dmiller
6995af0743
Note the fix to #1723 in changelog
2019-12-15 05:05:56 +00:00
david
5cc813f394
Fix an off-by-one error in stun.lua.
...
https://seclists.org/nmap-dev/2019/q4/8
2019-12-13 23:12:45 +00:00
dmiller
a5a945347b
Use keeppattern=true when using match.numbytes. Fixes #1855
2019-12-13 18:11:52 +00:00
dmiller
ff61845ce2
Avoid encoding errors in exception handler. See #1839
2019-12-10 20:51:56 +00:00
david
112fc96c50
Add UDP payload for STUN.
2019-12-06 23:16:43 +00:00
dmiller
33f421fd6e
Avoid assertion failure when unsolicited ARP response received
...
We probably want a more explicit handling of the case where we get an
ARP response to a request that we did not send (system's own, or another
Nmap scan running at the same time). In any case, this ought to solve
the crashes reported as #1797 and #1764 .
2019-12-03 17:04:13 +00:00
nnposter
e7e7e9e8c7
Fingerprint for Tomcat Host Manager. Closes #1755
2019-12-03 02:28:41 +00:00
dmiller
04a3effbed
Note that --iflist quits immediately without performing any scanning. Fixes #1835
2019-11-22 17:54:09 +00:00
dmiller
72fba4be5d
Use std::vector::clear() instead of empty() to clear a list
2019-11-22 17:51:54 +00:00
dmiller
f6ab7a898a
Clear up a name that conflicts with global 'ports' struct
2019-11-22 17:51:53 +00:00
dmiller
ed66ed03ec
Use unique header guards
2019-11-19 17:53:42 +00:00
dmiller
1a510d0940
Document Nmap modifications to libpcap 1.9.1.
2019-11-19 17:53:41 +00:00
dmiller
7789fc8446
Apply patch 1 to avoid rebuilding scanner and grammar files
2019-11-19 17:53:40 +00:00
dmiller
2d256eda3d
Generate libpcap files, remove extra content, apply patch 2
2019-11-19 17:53:39 +00:00
dmiller
f1107301e8
Update to libpcap 1.9.1 (initial commit, no Nmap-specific patches)
2019-11-19 17:53:36 +00:00
dmiller
42bb2feed8
Add 4433 (openssl s_server) to likely SSL ports
2019-11-18 18:31:39 +00:00
