dmiller dd40ba14ea Remove data packing atrocities from broadcast-ping.nse ...

Use of the "H" bin.unpack template should be discouraged, since it leads
to use of blobs of hex data without dissection. NSE scripts should be
self-documenting with regard to packet contents. Similarly, chaining
bin.pack and bin.unpack is usually an anti-pattern for some simpler
construct. In this case, converting a number to hex, padding it with
"0", and packing it is unnecessary, since the original number can be
packed directly with the proper endianness and width.

2015-02-10 04:49:28 +00:00

9.0 KiB

Raw Blame History

View Raw