Merge branch 'fix/issue-410-printnightmare' of github.com:peass-ng/PEASS-ng into fix/issue-410-printnightmare

.github/workflows/CI-master_tests.yml

@@ -48,23 +48,23 @@ jobs:
         
       # build
       - name: run MSBuild
-        run: msbuild $env:Solution_Path /p:Configuration=$env:Configuration /p:UseSharedCompilation=false
+        run: msbuild $env:Solution_Path
         
       # Execute all unit tests in the solution
-      - name: Execute unit tests
-        run: dotnet test $env:Solution_Path --configuration $env:Configuration
+      #- name: Execute unit tests
+      #  run: dotnet test $env:Solution_Path
         
       # Build & update all versions
       - name: Build all versions
         run: |
             echo "build x64"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x64" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x64"
             
             echo "build x86"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x86" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x86"
             
             echo "build Any CPU"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="Any CPU" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="Any CPU"
       
       - name: Execute winPEAS -h
         shell: pwsh
@@ -230,9 +230,6 @@ jobs:
           python3 -m builder.linpeas_builder --all --output linpeas_fat.sh
           python3 -m builder.linpeas_builder --all-no-fat --output linpeas.sh
           python3 -m builder.linpeas_builder --small --output linpeas_small.sh
-
-      - name: Run linPEAS builder tests
-        run: python3 -m unittest discover -s linPEAS/tests -p "test_*.py"
       
       # Build linpeas binaries
       - name: Build linpeas binaries 

.github/workflows/PR-tests.yml

@@ -42,23 +42,19 @@ jobs:
         
       # build
       - name: run MSBuild
-        run: msbuild $env:Solution_Path /p:Configuration=$env:Configuration /p:UseSharedCompilation=false
-
-      # Execute unit tests in the solution
-      - name: Execute unit tests
-        run: dotnet test $env:Solution_Path --configuration $env:Configuration
+        run: msbuild $env:Solution_Path
         
       # Build all versions
       - name: Build all versions
         run: |
             echo "build x64"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x64" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x64"
             
             echo "build x86"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x86" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="x86"
             
             echo "build Any CPU"
-            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="Any CPU" /p:UseSharedCompilation=false
+            msbuild -m $env:Solution_Path /t:Rebuild /p:Configuration=$env:Configuration /p:Platform="Any CPU"
       
       - name: Execute winPEAS -h
         shell: pwsh
@@ -127,9 +123,6 @@ jobs:
           python3 -m builder.linpeas_builder --all --output linpeas_fat.sh
           python3 -m builder.linpeas_builder --all-no-fat --output linpeas.sh
           python3 -m builder.linpeas_builder --small --output linpeas_small.sh
-
-      - name: Run linPEAS builder tests
-        run: python3 -m unittest discover -s linPEAS/tests -p "test_*.py"
       
       # Run linpeas help as quick test
       - name: Run linpeas help

.github/workflows/codex-pr-triage.yml

@@ -7,7 +7,6 @@ on:
 
 jobs:
   codex_triage:
-    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -132,7 +131,7 @@ jobs:
   merge_or_comment:
     runs-on: ubuntu-latest
     needs: codex_triage
-    if: ${{ github.event.workflow_run.conclusion == 'success' && needs.codex_triage.outputs.should_run == 'true' && needs.codex_triage.outputs.decision != '' }}
+    if: ${{ needs.codex_triage.outputs.should_run == 'true' && needs.codex_triage.outputs.decision != '' }}
     permissions:
       contents: write
       pull-requests: write

.github/workflows/pr-failure-codex-dispatch.yml

@@ -6,7 +6,7 @@ on:
     types: [completed]
 
 jobs:
-  resolve_pr_context:
+  codex_on_failure:
     if: >
       ${{ github.event.workflow_run.conclusion == 'failure' &&
           github.event.workflow_run.pull_requests &&
@@ -14,14 +14,11 @@ jobs:
           !startsWith(github.event.workflow_run.head_commit.message, 'Fix CI failures for PR #') }}
     runs-on: ubuntu-latest
     permissions:
-      pull-requests: read
-      issues: read
-    outputs:
-      number: ${{ steps.pr_context.outputs.number }}
-      author: ${{ steps.pr_context.outputs.author }}
-      head_repo: ${{ steps.pr_context.outputs.head_repo }}
-      head_branch: ${{ steps.pr_context.outputs.head_branch }}
-      should_run: ${{ steps.pr_context.outputs.should_run }}
+      contents: write
+      pull-requests: write
+      issues: write
+      actions: read
+
     steps:
       - name: Resolve PR context
         id: pr_context
@@ -38,37 +35,18 @@ jobs:
           pr_head_branch=$(gh api -H "Accept: application/vnd.github+json" \
             /repos/${{ github.repository }}/pulls/${PR_NUMBER} \
             --jq '.head.ref')
-          pr_labels=$(gh api -H "Accept: application/vnd.github+json" \
-            /repos/${{ github.repository }}/issues/${PR_NUMBER} \
-            --jq '.labels[].name')
-          if echo "$pr_labels" | grep -q "^codex-fix-attempted$"; then
-            echo "codex fix already attempted for PR #${PR_NUMBER}; skipping."
-            should_run=false
-          else
-            should_run=true
-          fi
           {
             echo "number=${PR_NUMBER}"
             echo "author=${pr_author}"
             echo "head_repo=${pr_head_repo}"
             echo "head_branch=${pr_head_branch}"
-            echo "should_run=${should_run}"
           } >> "$GITHUB_OUTPUT"
 
-  codex_on_failure:
-    needs: resolve_pr_context
-    if: ${{ needs.resolve_pr_context.outputs.author == 'carlospolop' && needs.resolve_pr_context.outputs.should_run == 'true' }}
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pull-requests: write
-      issues: write
-      actions: read
-    steps:
       - name: Comment on PR with failure info
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         uses: actions/github-script@v7
         env:
-          PR_NUMBER: ${{ needs.resolve_pr_context.outputs.number }}
+          PR_NUMBER: ${{ steps.pr_context.outputs.number }}
           RUN_URL: ${{ github.event.workflow_run.html_url }}
           WORKFLOW_NAME: ${{ github.event.workflow_run.name }}
         with:
@@ -83,30 +61,23 @@ jobs:
               body,
             });
 
-      - name: Mark fix attempt
-        env:
-          PR_NUMBER: ${{ needs.resolve_pr_context.outputs.number }}
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          gh api -X POST -H "Accept: application/vnd.github+json" \
-            /repos/${{ github.repository }}/issues/${PR_NUMBER}/labels \
-            -f labels='["codex-fix-attempted"]'
-
       - name: Checkout PR head
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         uses: actions/checkout@v5
         with:
-          repository: ${{ needs.resolve_pr_context.outputs.head_repo }}
+          repository: ${{ steps.pr_context.outputs.head_repo }}
           ref: ${{ github.event.workflow_run.head_sha }}
           fetch-depth: 0
           persist-credentials: true
-          token: ${{ secrets.CODEX_FIXER_TOKEN }}
 
       - name: Configure git author
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         run: |
           git config user.name "codex-action"
           git config user.email "codex-action@users.noreply.github.com"
 
       - name: Fetch failure summary
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         env:
           GH_TOKEN: ${{ github.token }}
           RUN_ID: ${{ github.event.workflow_run.id }}
@@ -134,10 +105,11 @@ jobs:
           PY
 
       - name: Create Codex prompt
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         env:
-          PR_NUMBER: ${{ needs.resolve_pr_context.outputs.number }}
+          PR_NUMBER: ${{ steps.pr_context.outputs.number }}
           RUN_URL: ${{ github.event.workflow_run.html_url }}
-          HEAD_BRANCH: ${{ needs.resolve_pr_context.outputs.head_branch }}
+          HEAD_BRANCH: ${{ steps.pr_context.outputs.head_branch }}
         run: |
           {
             echo "You are fixing CI failures for PR #${PR_NUMBER} in ${{ github.repository }}."
@@ -153,6 +125,7 @@ jobs:
           } > codex_prompt.txt
 
       - name: Run Codex
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         id: run_codex
         uses: openai/codex-action@v1
         with:
@@ -162,9 +135,10 @@ jobs:
           model: gpt-5.2-codex
 
       - name: Commit and push if changed
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' }}
         env:
-          TARGET_BRANCH: ${{ needs.resolve_pr_context.outputs.head_branch }}
-          PR_NUMBER: ${{ needs.resolve_pr_context.outputs.number }}
+          TARGET_BRANCH: ${{ steps.pr_context.outputs.head_branch }}
+          PR_NUMBER: ${{ steps.pr_context.outputs.number }}
         run: |
           if git diff --quiet; then
             echo "No changes to commit."
@@ -177,10 +151,10 @@ jobs:
           git push origin HEAD:${TARGET_BRANCH}
 
       - name: Comment with Codex result
-        if: ${{ steps.run_codex.outputs.final-message != '' }}
+        if: ${{ steps.pr_context.outputs.author == 'carlospolop' && steps.run_codex.outputs.final-message != '' }}
         uses: actions/github-script@v7
         env:
-          PR_NUMBER: ${{ needs.resolve_pr_context.outputs.number }}
+          PR_NUMBER: ${{ steps.pr_context.outputs.number }}
           CODEX_MESSAGE: ${{ steps.run_codex.outputs.final-message }}
         with:
           github-token: ${{ github.token }}

linPEAS/builder/linpeas_parts/7_software_information/Browser_profiles.sh

@@ -1,5 +1,5 @@
 # Title: Software Information - Browser Profiles
-# ID: SW_Browser_profiles
+# ID: SW_Browser_Profiles
 # Author: Carlos Polop
 # Last Update: 10-03-2025
 # Description: List browser profiles that may store credentials/cookies

linPEAS/tests/test_builder.py

@@ -1,40 +0,0 @@
-import os
-import stat
-import subprocess
-import tempfile
-import unittest
-from pathlib import Path
-
-
-class LinpeasBuilderTests(unittest.TestCase):
-    def setUp(self):
-        self.repo_root = Path(__file__).resolve().parents[2]
-        self.linpeas_dir = self.repo_root / "linPEAS"
-
-    def _run_builder(self, args, output_path):
-        cmd = ["python3", "-m", "builder.linpeas_builder"] + args + ["--output", str(output_path)]
-        result = subprocess.run(cmd, cwd=str(self.linpeas_dir), capture_output=True, text=True)
-        if result.returncode != 0:
-            raise AssertionError(
-                f"linpeas_builder failed:\nstdout:\n{result.stdout}\nstderr:\n{result.stderr}"
-            )
-
-    def test_small_build_creates_executable(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            output_path = Path(tmpdir) / "linpeas_small.sh"
-            self._run_builder(["--small"], output_path)
-            self.assertTrue(output_path.exists(), "linpeas_small.sh was not created.")
-            mode = output_path.stat().st_mode
-            self.assertTrue(mode & stat.S_IXUSR, "linpeas_small.sh is not executable.")
-
-    def test_include_exclude_modules(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            output_path = Path(tmpdir) / "linpeas_include.sh"
-            self._run_builder(["--include", "system_information,container", "--exclude", "container"], output_path)
-            content = output_path.read_text(encoding="utf-8", errors="ignore")
-            self.assertIn("Operative system", content)
-            self.assertNotIn("Am I Containered?", content)
-
-
-if __name__ == "__main__":
-    unittest.main()

parsers/peas2json.py

@@ -127,9 +127,7 @@ def parse_line(line: str):
 
     elif is_section(line, INFO_PATTERN):
         title = parse_title(line)
-        if C_SECTION == {}:
-            return
-        C_SECTION.setdefault("infos", []).append(title)
+        C_SECTION["infos"].append(title)
     
     #If here, then it's text
     else:

winPEAS/winPEASexe/CMakeLists.txt

@@ -1,26 +0,0 @@
-cmake_minimum_required(VERSION 3.16)
-project(winPEAS_dotnet NONE)
-
-set(PROJECT_FILE "${CMAKE_CURRENT_SOURCE_DIR}/winPEAS.csproj")
-
-find_program(DOTNET_EXECUTABLE dotnet)
-find_program(MSBUILD_EXECUTABLE msbuild)
-find_program(XBUILD_EXECUTABLE xbuild)
-
-if(DOTNET_EXECUTABLE)
-  set(BUILD_TOOL "${DOTNET_EXECUTABLE}")
-  set(BUILD_ARGS build "${PROJECT_FILE}" -c Release)
-elseif(MSBUILD_EXECUTABLE)
-  set(BUILD_TOOL "${MSBUILD_EXECUTABLE}")
-  set(BUILD_ARGS "${PROJECT_FILE}" /p:Configuration=Release)
-elseif(XBUILD_EXECUTABLE)
-  set(BUILD_TOOL "${XBUILD_EXECUTABLE}")
-  set(BUILD_ARGS "${PROJECT_FILE}" /p:Configuration=Release)
-else()
-  message(FATAL_ERROR "dotnet, msbuild, or xbuild is required to build winPEAS")
-endif()
-
-add_custom_target(winpeas ALL
-  COMMAND ${BUILD_TOOL} ${BUILD_ARGS}
-  WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
-)

winPEAS/winPEASexe/Tests/ArgumentParsingTests.cs

@@ -1,36 +0,0 @@
-using System;
-using System.Reflection;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
-using winPEAS.Checks;
-
-namespace winPEAS.Tests
-{
-    [TestClass]
-    public class ArgumentParsingTests
-    {
-        private static bool InvokeIsNetworkTypeValid(string arg)
-        {
-            var method = typeof(Checks).GetMethod("IsNetworkTypeValid", BindingFlags.NonPublic | BindingFlags.Static);
-            Assert.IsNotNull(method, "IsNetworkTypeValid method not found.");
-            return (bool)method.Invoke(null, new object[] { arg });
-        }
-
-        [TestMethod]
-        public void ShouldAcceptValidNetworkTypes()
-        {
-            Assert.IsTrue(InvokeIsNetworkTypeValid("-network=auto"));
-            Assert.IsTrue(InvokeIsNetworkTypeValid("-network=10.10.10.10"));
-            Assert.IsTrue(InvokeIsNetworkTypeValid("-network=10.10.10.10/24"));
-            Assert.IsTrue(InvokeIsNetworkTypeValid("-network=10.10.10.10,10.10.10.20"));
-        }
-
-        [TestMethod]
-        public void ShouldRejectInvalidNetworkTypes()
-        {
-            Assert.IsFalse(InvokeIsNetworkTypeValid("-network="));
-            Assert.IsFalse(InvokeIsNetworkTypeValid("-network=10.10.10.999"));
-            Assert.IsFalse(InvokeIsNetworkTypeValid("-network=10.10.10.10/64"));
-            Assert.IsFalse(InvokeIsNetworkTypeValid("-network=not-an-ip"));
-        }
-    }
-}

winPEAS/winPEASexe/Tests/winPEAS.Tests.csproj

@@ -95,7 +95,6 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <Compile Include="ArgumentParsingTests.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="SmokeTests.cs" />
   </ItemGroup>
@@ -134,4 +133,4 @@
   <Import Project="..\packages\Stub.System.Data.SQLite.Core.NetFramework.1.0.119.0\build\net451\Stub.System.Data.SQLite.Core.NetFramework.targets" Condition="Exists('..\packages\Stub.System.Data.SQLite.Core.NetFramework.1.0.119.0\build\net451\Stub.System.Data.SQLite.Core.NetFramework.targets')" />
   <Import Project="..\packages\Fody.6.5.5\build\Fody.targets" Condition="Exists('..\packages\Fody.6.5.5\build\Fody.targets')" />
   <Import Project="..\packages\Costura.Fody.5.7.0\build\Costura.Fody.targets" Condition="Exists('..\packages\Costura.Fody.5.7.0\build\Costura.Fody.targets')" />
-</Project>
+</Project>

winPEAS/winPEASexe/winPEAS/Program.cs

@@ -11,7 +11,6 @@ namespace winPEAS
         [STAThread]
         public static void Main(string[] args)
         {
-            // TODO: keep Main minimal; this line was an intentional break in test PR.
             Checks.Checks.Run(args);
         }
     }