SimCompanies/dashboard
2
1
Fork 0
Code Issues 17 Pull Requests Releases Activity

ui-improvements #23

Merged
oliver merged 3 commits from ui-improvements into master 2020-04-18 20:34:15 +00:00
Conversation 1 Commits 3 Files Changed 6 +179 -55
falk commented 2020-04-18 20:07:01 +00:00
Collaborator
Copy Link
No description provided.
falk added this to the MVP Version 0.1 milestone 2020-04-18 20:07:01 +00:00
falk added the frontend label 2020-04-18 20:07:01 +00:00
oliver was assigned by falk 2020-04-18 20:07:01 +00:00
oliver approved these changes 2020-04-18 20:15:37 +00:00
oliver left a comment
Owner
Copy Link

lgtm

lgtm
frontend/src/components/resourcechart/resourcechart.js
@@ -10,0 +21,4 @@
const output = (data) => {
if (data === null) {
return (
<CircularProgress color="secondary" />
oliver commented 2020-04-18 20:14:30 +00:00
Owner
Copy Link

Nice

Nice
frontend/src/components/selectResource/index.js
@@ -43,7 +21,7 @@ export default function SelectResource() {
resourceJSON = await resourceJSON.json();
let rArr = [];
for (let i = 0; i < resourceJSON.length; i++) {
rArr.push(CreateResourceCard(resourceJSON[i], classes));
oliver commented 2020-04-18 20:15:15 +00:00
Owner
Copy Link

Nice

Nice
oliver closed this pull request 2020-04-18 20:34:14 +00:00
oliver deleted branch ui-improvements 2020-04-18 20:34:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
oliver
Labels
Clear labels
backend
affecting backend only
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
affecting frontend only
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone MVP Version 0.1
Assignees
Clear assignees
falk oliver
No Assignees oliver
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SimCompanies/dashboard#23
Delete Branch "ui-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?