SimCompanies/dashboard
2
1
Fork 0
Code Issues 17 Pull Requests Releases Activity

login-feedback #44

Merged
oliver merged 9 commits from login-feedback into master 2020-04-30 21:04:42 +00:00
Conversation 2 Commits 9 Files Changed 7 +199 -65
falk commented 2020-04-30 19:32:11 +00:00
Collaborator
Copy Link
No description provided.
falk added this to the MVP Version 0.1 milestone 2020-04-30 19:32:11 +00:00
falk added the frontend label 2020-04-30 19:32:11 +00:00
oliver was assigned by falk 2020-04-30 19:32:11 +00:00
falk added the enhancement label 2020-04-30 19:36:25 +00:00
oliver requested changes 2020-04-30 19:40:04 +00:00
oliver left a comment
Owner
Copy Link

ignoreignoreignoreignore tmaybemaybedeactimaybemaybedeactimaybemaybedeactivamaybemaybedeactiva

ignoreignoreignoreignore tmaybemaybedeactimaybemaybedeactimaybemaybedeactivamaybemaybedeactiva
frontend/src/components/login/createAccount.js Outdated
@@ -96,1 +95,4 @@
}
const handleKeyDown = (e) => {
if (e.keyCode == 13) {
oliver commented 2020-04-30 19:36:26 +00:00
Owner
Copy Link

e.key === 'Enter' would be cleaner

e.key === 'Enter' would be cleaner
frontend/src/components/login/createAccount.js Outdated
@@ -157,6 +171,7 @@ export default function CreateAccount() {
</form>
</CardContent>
</Card>
<LoginFeedback login={status} successText="Account created successfully" errorText="Oops something went wrong"></LoginFeedback>
oliver commented 2020-04-30 19:38:51 +00:00
Owner
Copy Link

Can you use the message supplied by the Backend If an Error occurs?

Can you use the message supplied by the Backend If an Error occurs?
frontend/src/components/login/login.js Outdated
@@ -97,1 +101,4 @@
}
const handleKeyDown = (e) => {
if (e.keyCode == 13) {
oliver commented 2020-04-30 19:37:12 +00:00
Owner
Copy Link

Same here

Same here
frontend/src/components/login/login.js Outdated
@@ -169,6 +189,7 @@ export default function Login() {
</form>
</CardContent>
</Card>
<LoginFeedback login={status} successText="Login Successful" errorText="Wrong Username or Password"></LoginFeedback>
oliver commented 2020-04-30 19:39:08 +00:00
Owner
Copy Link

Same here

Same here
oliver approved these changes 2020-04-30 21:04:33 +00:00
oliver left a comment
Owner
Copy Link

lgtm

lgtm
oliver closed this pull request 2020-04-30 21:04:42 +00:00
oliver deleted branch login-feedback 2020-04-30 21:04:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
oliver
Labels
Clear labels
backend
affecting backend only
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
affecting frontend only
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label enhancement frontend
Milestone
No items
No Milestone MVP Version 0.1
Assignees
Clear assignees
falk oliver
No Assignees oliver
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SimCompanies/dashboard#44
Delete Branch "login-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?