dmiller
a87b0ca133
Add version info for MS SQL 2017 and 2019
2020-01-06 18:39:54 +00:00
dmiller
81f0818d9e
http-enum: Fingerprint for ArangoDB
2020-01-06 18:24:34 +00:00
dmiller
81ceee49c5
sslcert: Try tls.lua if Nsock's SSL routines fail to connect.
2020-01-06 18:24:33 +00:00
dmiller
b9d14a40ab
Be more strict about what we parse as TLS record data
2020-01-06 18:24:32 +00:00
dmiller
d3b888bf4f
Update postgresql service match lines
2020-01-04 23:18:00 +00:00
dmiller
a16c392f2d
Process some service fingerprint submissions.
...
Related: #1639
2020-01-04 22:52:20 +00:00
dmiller
f8846c2c39
Add a tostring metamethod for bignum objects. See #1876
2020-01-03 16:54:59 +00:00
nnposter
0f3a8a7e0d
* Cryptographic numbers should be output as such,
...
not as userdata pointers to opaque data structures. Fixes #1876
2020-01-02 23:31:16 +00:00
dmiller
a66c287b06
Loop over client FDs, avoiding unused ones
...
As the FIXME comment had said, looping over every integer up to maxfd is
inefficient, especially if FDs are not continuous. This change has the
added benefit of skipping a call to get_fdinfo(), which also loops over
all the client FDs looking for a particular value. Unlikely to be a huge
performance gain, but the code is cleaner. #1834 - FIXME comment.
2020-01-02 16:04:30 +00:00
dmiller
2f91473a06
Remove FIXME comment: newstrlen *is* checked.
...
I added this a long time ago, and decided to check it. In fact,
newstrlen is used to calculate newstrend, and each section of the
template is checked to ensure it does not go past newstrend, so the
intent is met and the length is not exceeded. I still think it could be
written more clearly, but it's good for now. #1834
2020-01-02 16:04:29 +00:00
dmiller
ea8917ca1d
Remove a script that exists elsewhere in updated format.
2020-01-01 23:04:53 +00:00
dmiller
ef52628bbc
Remove unused variable. #1834
2020-01-01 23:04:52 +00:00
dmiller
e01ddaf1e8
Avoid retrying iod_read if we already got ENOTSOCK.
2019-12-30 16:14:10 +00:00
dmiller
c7932d2fc6
Don't break out of loop on just any error, since loop condition expects to test for EINTR. #1834
2019-12-30 16:14:09 +00:00
dmiller
f3f3a8367e
Don't check for char greater than CHAR_MAX. #1834
2019-12-30 16:14:09 +00:00
dmiller
c89035b6dd
Avoid 'import *' where __all__ not defined. #1834
2019-12-30 15:54:34 +00:00
dmiller
2abcac9925
Don't bother maintaining compat with Python 2.5. #1834
2019-12-30 06:57:04 +00:00
dmiller
d75e255113
Avoid handling BaseException, so SysExit and KeyboardInterrupt are propagated. #1834
2019-12-30 06:46:36 +00:00
dmiller
74708c3e3a
Hash Port objects by port spec, fixing breakage
2019-12-30 06:46:35 +00:00
dmiller
3e58be1551
Use 'with' statements for file open/close. #1834
2019-12-30 06:46:34 +00:00
dmiller
02212559d2
Delete unused variables and unreachable statements. #1834
2019-12-30 06:46:33 +00:00
dmiller
65450a0654
Actually delete Nmap output object in property deleter method. #1834
2019-12-30 06:46:32 +00:00
dmiller
33aca7c8f5
Avoid using for/else when loop doesn't break. #1834
2019-12-30 06:46:32 +00:00
dmiller
d3267a93c4
Fix a crash, config_parser referenced before assignment.
2019-12-30 05:05:39 +00:00
dmiller
499c07d9f9
Replace redundant function, permit ranges in udp payload specs.
2019-12-30 04:48:50 +00:00
dmiller
697a22fd63
Move some flag defines from services.h to scan_lists.h where they make more sense.
2019-12-30 04:48:50 +00:00
dmiller
17304bf825
Remove debug to file from OS X launcher. Closes #1777
2019-12-30 04:48:49 +00:00
dmiller
ea4e2d6657
Avoid 'using namespace std' causing name conflicts. Fixes #1363 , fixes #1867
2019-12-30 04:03:03 +00:00
dmiller
085cd7fd34
Suppress unused import LGTM.com alert for I18N
...
I18N installs the `_` function into the builtin namespace, so it looks
like it's unused when it's not. #1834
2019-12-30 00:53:25 +00:00
dmiller
866dc375e4
Correctly print VM socket address. Closes #1868
2019-12-30 00:53:23 +00:00
dmiller
254d155634
Update LGTM config to skip javascript analysis, which fails anyway since we don't have any.
2019-12-29 20:18:52 +00:00
dmiller
156cb98fd0
Fix up some LGTM issues in ndiff. #1834
2019-12-29 20:05:05 +00:00
dmiller
33346f7651
Remove unused variables. #1834
2019-12-29 19:56:26 +00:00
dmiller
92270f313e
Fix some 'import *' messiness. #1834
2019-12-29 19:56:26 +00:00
dmiller
e3f884a301
Silence some LGTM warnings, since the script is modified on install. #1834
2019-12-29 19:28:57 +00:00
dmiller
2a0c1eca5c
Remove unused variables. #1834
2019-12-29 19:28:56 +00:00
dmiller
fa7cdb2c9f
Remove unneeded delete (var goes out of scope). #1834
2019-12-29 15:57:31 +00:00
dmiller
0403751060
Be more clear for static analysis (LGTM) that this does not overflow. #1834
2019-12-29 15:52:59 +00:00
dmiller
ee95fa8d30
Avoid extra copying of sockaddr storage; pass by reference. #1834
2019-12-29 15:52:58 +00:00
dmiller
3618f48b89
Instruct LGTM to ignore short names of global variables. #1834
2019-12-29 15:52:58 +00:00
dmiller
1059e25a7b
Avoid hiding global with parameter. #1834
2019-12-29 06:18:33 +00:00
dmiller
3c7f2de01b
Properly return negative on error from vsnprintf
...
Our implementation of vsnprintf for systems where it is missing did not
correctly return a negative value on error, instead returning the size
passed in. We got this code from tcpdump/libpcap, and it was wrong
there, too, though their latest master branch has removed it in favor of
requiring a C99 compiler (C99 guarantees vsnprintf).
This should remove a LGTM code analysis finding (See #1834 ) of
cpp/constant-comparison in Ncat because we were checking for a negative
return from Snprintf, which would never occur.
2019-12-29 05:53:27 +00:00
dmiller
736cefcdb6
Pass ScriptResult by const reference instead of copying. #1834
2019-12-29 05:15:12 +00:00
dmiller
784142022d
Make destructor virtual (no effect at the moment). #1834
2019-12-29 05:15:11 +00:00
dmiller
5e30d6e29e
Fix loop flow. #1834
2019-12-29 05:15:10 +00:00
dmiller
b74f70fb33
Avoid integer overflow in multiplication. See #1834
2019-12-29 05:15:10 +00:00
dmiller
d5b57a8cd9
Replace ncat's custom hexdump function with the one from nbase.
2019-12-28 20:12:45 +00:00
dmiller
92bf83aaba
Remove unused imports
2019-12-28 02:42:14 +00:00
dmiller
6d624f9ed7
Correct function prototypes from earlier change
2019-12-26 16:46:18 +00:00
dmiller
898988dcd3
Remove dangling else
2019-12-26 16:46:17 +00:00
